1 |
Dnia 2015-10-14, o godz. 22:10:38 |
2 |
Ulrich Mueller <ulm@g.o> napisał(a): |
3 |
|
4 |
> >>>>> On Wed, 14 Oct 2015, Michał Górny wrote: |
5 |
> |
6 |
> >> Hm, I previously had "IF the first parameter begins with a hyphen |
7 |
> >> AND any parameter is equal to --", because the first parameter |
8 |
> >> certainly cannot be an option argument. |
9 |
> |
10 |
> > I know. But does it really make a difference in our case? I wanted |
11 |
> > to try to make the algorithm a little simpler. |
12 |
> |
13 |
> *shrug* Let GNU patch choke on it then. |
14 |
> |
15 |
> >> > +\ELSIF{any parameter beginning with a hyphen follows one that does not begin with a hyphen} |
16 |
> >> > + \STATE abort the build process with an error |
17 |
> >> |
18 |
> >> I suggest "return immediately with an error" here, for consistency |
19 |
> >> with the wording below. |
20 |
> |
21 |
> > Well, I wanted to emphasize difference in error handling. patch |
22 |
> > failing implies error exit with respect to nonfatal. Usage error is |
23 |
> > unconditional die. |
24 |
> |
25 |
> I see, but then the wording might be more explicit. Maybe instead of |
26 |
> "If it fails" say "If applying the patches fails" in the description? |
27 |
|
28 |
Done. Let me resubmit once again. |
29 |
|
30 |
-- |
31 |
Best regards, |
32 |
Michał Górny |
33 |
<http://dev.gentoo.org/~mgorny/> |