Gentoo Archives: gentoo-pms

From: "Ulrich Müller" <ulm@g.o>
To: gentoo-pms@l.g.o
Cc: "Ulrich Müller" <ulm@g.o>
Subject: [gentoo-pms] [PATCH] eclasses.tex: Clarify precedence of EXPORT_FUNCTIONS calls
Date: Mon, 30 Aug 2021 07:48:20
Message-Id: 20210830074808.7884-1-ulm@gentoo.org
1 Clarify that the last call to EXPORT_FUNCTIONS takes precedence over
2 earlier calls.
3
4 Unfortunately, we need an exception when inherit is called after
5 EXPORT_FUNCTIONS because Portage changed its behaviour in 2009:
6 https://gitweb.gentoo.org/proj/portage.git/commit/?id=06d4433e8b8be60d606733b9e23f57f8a5869d8f
7
8 Pkgcore and Paludis apply precedence consistently based on call order
9 of EXPORT_FUNCTIONS.
10
11 Closes: https://bugs.gentoo.org/399039
12 Closes: https://bugs.gentoo.org/422513
13 Signed-off-by: Ulrich Müller <ulm@g.o>
14 ---
15 eclasses.tex | 4 ++++
16 1 file changed, 4 insertions(+)
17
18 diff --git a/eclasses.tex b/eclasses.tex
19 index a92ce1f..e23dcd8 100644
20 --- a/eclasses.tex
21 +++ b/eclasses.tex
22 @@ -88,6 +88,10 @@ should the author wish to override it he can access the function in \t{foo.eclas
23 \t{EXPORT_FUNCTIONS} must only be used on ebuild phase functions. The function that is aliased
24 must be named \t{eclassname_phasefunctionname}, where \t{eclassname} is the name of the eclass.
25
26 +If \t{EXPORT_FUNCTIONS} is called multiple times for the same phase function, the last call takes
27 +precedence. Eclasses may not rely upon any particular behaviour if they inherit another eclass
28 +after calling \t{EXPORT_FUNCTIONS}.
29 +
30 % vim: set filetype=tex fileencoding=utf8 et tw=100 spell spelllang=en :
31
32 %%% Local Variables:
33 --
34 2.33.0