Re: [gentoo-pms] [PATCH] ebuild-vars.tex: Clarify which variables can be defined by an eclass

[Sam James]

> On 17 Mar 2022, at 19:01, Ulrich Müller <ulm@g.o> wrote:
>
> Signed-off-by: Ulrich Müller <ulm@g.o>
> ---
> ebuild-vars.tex | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/ebuild-vars.tex b/ebuild-vars.tex
> index d07cca4..e7aab0a 100644
> --- a/ebuild-vars.tex
> +++ b/ebuild-vars.tex
> @@ -43,8 +43,9 @@ All ebuilds must define at least the following variables:
> \section{Optional Ebuild-defined Variables}
> \label{sec:optional-vars}
>
> -Ebuilds may define any of the following variables:
> -\nobreakpar
> +Ebuilds may define any of the following variables. Unless otherwise stated, any of them may be
> +defined by an eclass.
> +
> \begin{description}
> \item[EAPI] The EAPI\@. See below in section~\ref{sec:eapi}.
> \item[HOMEPAGE] The URI or URIs for a package's homepage, including protocols.
> @@ -147,6 +148,8 @@ EAPI, the package manager must make sure that the \t{EAPI} value obtained by sou
> with bash is identical to the EAPI obtained by parsing. The ebuild must be treated as invalid if
> these values are different.
>
> +Eclasses must not attempt to modify the \t{EAPI} variable.
> +
> \subsection{SRC_URI}
> \label{sec:src-uri-behaviour}
>

lgtm

best,
sam