Re: [gentoo-pms] [PATCH eapi8] EAPI 8 has install-time dependencies (IDEPEND)

[Michał Górny]

On Mon, 2019-12-23 at 08:21 +0100, Ulrich Mueller wrote:
> > > > > > On Sun, 22 Dec 2019, Michał Górny wrote:
> > --- a/dependencies.tex
> > +++ b/dependencies.tex
> > @@ -21,7 +21,7 @@
> >            \t{src_install} & \t{DEPEND}, \t{BDEPEND} \\
> >        \addlinespace
> >        \t{pkg_preinst}, \t{pkg_postinst}, \t{pkg_prerm}, \t{pkg_postrm} &
> > -          \t{RDEPEND} \\
> > +          \t{RDEPEND}, \t{IDEPEND} \\
>
> This would imply that in order to uninstall a package, the PM would
> possibly have to install other packages listed in IDEPEND. Do we really
> want to go down that road? (What if there are circular dependencies in
> IDEPEND?)

I've already indicated below that they may not be available.  Do you
want me to repeat that here somehow, or just omit it entirely?

>
> > @@ -30,15 +30,16 @@
> >
> >  \begin{centertable}{Summary of other interfaces related to dependency classes}
> >      \label{tab:dep-class-api}
> > -    \begin{tabular}{llll}
> > +    \begin{tabular}{lllll}
>
> But it's still 4 columns, isn't it?

Yep, fixed.

>
> >        \toprule
> > -                                & \t{BDEPEND}     & \t{DEPEND}         & \t{RDEPEND}, \t{PDEPEND} \\
> > +                                & \t{BDEPEND}, \t{IDEPEND} & \t{DEPEND}         & \t{RDEPEND},
> > +                                                                                  \t{PDEPEND}       \\
>
> Just move the first & tab to the left, then you need not split the line
> (and see the following remark below).

Good idea, done.

>
> >        \midrule
> > -      Binary compatible with    & \t{CBUILD}      & \t{CHOST}          & \t{CHOST}         \\
> > -      Base unprefixed path      & \t{/}           & \t{\$\{SYSROOT\}}  & \t{\$\{ROOT\}}    \\
> > -      Relevant offset-prefix    & \t{\$\{BROOT\}} & \t{\$\{EPREFIX\}}  & \t{\$\{EPREFIX\}} \\
> > -      Path combined with prefix & \t{\$\{BROOT\}} & \t{\$\{ESYSROOT\}} & \t{\$\{EROOT\}}   \\
> > -      PM query command option   & \t{-b}          & \t{-d}             & \t{-r}            \\
> > +      Binary compatible with    & \t{CBUILD}               & \t{CHOST}          & \t{CHOST}         \\
> > +      Base unprefixed path      & \t{/}                    & \t{\$\{SYSROOT\}}  & \t{\$\{ROOT\}}    \\
> > +      Relevant offset-prefix    & \t{\$\{BROOT\}}          & \t{\$\{EPREFIX\}}  & \t{\$\{EPREFIX\}} \\
> > +      Path combined with prefix & \t{\$\{BROOT\}}          & \t{\$\{ESYSROOT\}} & \t{\$\{EROOT\}}   \\
> > +      PM query command option   & \t{-b}                   & \t{-d}             & \t{-r}            \\
>
> Nothing has changed here? Maybe better to leave the whitespace alone.

Restored original whitespace.

>
> > +\featurelabel{idepend} Additionally, in EAPIs listed in table~\ref{tab:depend-table} as supporting
> > +\t{IDEPEND}, install-time dependencies can be specified. Those dependencies are binary compatible
> > +with the native build system (\t{CBUILD}). The~ebuild is allowed to call them in \t{pkg_preinst}
> > +and \t{pkg_postinst} phases. The ebuild may also call them in \t{pkg_prerm} and \t{pkg_postrm}
> > +but must not rely on them being available.
>
> s/Those/These/
> s/The ebuild/Ebuilds/ (twice)
> s/ phases// (these are not phases, but phase _functions_)

Done.

>
> > @@ -97,7 +106,7 @@ be surrounded on both sides by whitespace, except at the start and end of the st
> >
> >  \begin{compactitem}
> >  \item A package dependency specification. Permitted in \t{DEPEND}, \t{BDEPEND}, \t{RDEPEND},
> > -    \t{PDEPEND}.
> > +    \t{IDEPEND}, \t{PDEPEND}.
>
> Hm, I guess it's time to establish a canonical order of these variables.
> You say, IDEPEND should be listed before PDEPEND? (On first thought, I'd
> have listed IDEPEND at the end, because RDEPEND and PDEPEND are similar.
> Or IDEPEND after BDEPEND.)

My logic was that PDEPEND is used very rarely, so it should go last. 
However, your idea also makes sense.

>
> > --- a/ebuild-env-vars.tex
> > +++ b/ebuild-env-vars.tex
> > @@ -147,9 +147,10 @@ variable.
> >  \t{BROOT} &
> >      Ditto &
> >      No &
> > -    \featurelabel{broot} The absolute path to the root directory containing build dependencies
> > -    satisfied by \t{BDEPEND}, typically executable build tools. This includes any applicable offset
> > -    prefix. Only for EAPIs listed in table~\ref{tab:offset-env-vars-table} as supporting \t{BROOT}.
> > +    \featurelabel{broot} The absolute path to the root directory containing build host dependencies
>
> I think you shouldn't change "build" to "build host" here, because of
> the confusion with CHOST. The following "executable build tools" makes
> it clear enough what is meant.
>
> (Or if we change that wording, then we should do it now, and not as part
> of an EAPI 8 patch.)

'Host' removed.

>
> > +    satisfied by \t{BDEPEND} and \t{IDEPEND}, typically executable build tools. This includes any
> > +    applicable offset prefix. Only for EAPIs listed in table~\ref{tab:offset-env-vars-table} as
> > +    supporting \t{BROOT}.
> > --- a/ebuild-vars.tex
> > +++ b/ebuild-vars.tex
> > @@ -86,6 +86,7 @@ Ebuilds may define any of the following variables:
> >      details.
> >  \item[PDEPEND] See chapter~\ref{ch:dependencies}.
> >  \item[BDEPEND] See chapter~\ref{ch:dependencies}.
> > +\item[IDEPEND] See chapter~\ref{ch:dependencies}.
>
> Here the order is different from the one used above (but it's like this
> in EAPI 7 already).
>

Yes, that's why I added it last -- presumed it's in addition order.

Lemme know which order should I use finally, and if I should update this
one as well (in a separate patch?).

-- 
Best regards,
Michał Górny