Gentoo Archives: gentoo-pms

From: Ulrich Mueller <ulm@g.o>
To: gentoo-pms@l.g.o
Subject: Re: [gentoo-pms] [PATCH] ebuild-functions.tex: Update array detection code.
Date: Tue, 18 Feb 2020 10:21:01
Message-Id: w6gimk419j4.fsf@kph.uni-mainz.de
In Reply to: [gentoo-pms] [PATCH] ebuild-functions.tex: Update array detection code. by "Ulrich Müller"
1 >>>>> On Sat, 15 Feb 2020, Ulrich Müller wrote:
2
3 > Remove the space after "declare -a" for matching "declare -p" output.
4 > With the update of the bash version to 4.2 in EAPI 6, variables can
5 > have other attributes in addition, which would make the test fail.
6 > For example, see https://bugs.gentoo.org/444832#c7. The implementation
7 > in Portage already omits the space.
8
9 > Replace grep by functionally equivalent code in bash. This is how the
10 > test is implemented in package managers, and follows the principle
11 > that external programs should not be called unnecessarily.
12
13 > Redirect stderr for "declare -p", because it outputs an error message
14 > if the PATCHES variable is not defined.
15
16 Pushed.

Attachments

File name MIME type
signature.asc application/pgp-signature