1 |
>>>>> On Wed, 14 Oct 2015, Michał Górny wrote: |
2 |
|
3 |
>> Hm, I previously had "IF the first parameter begins with a hyphen |
4 |
>> AND any parameter is equal to --", because the first parameter |
5 |
>> certainly cannot be an option argument. |
6 |
|
7 |
> I know. But does it really make a difference in our case? I wanted |
8 |
> to try to make the algorithm a little simpler. |
9 |
|
10 |
*shrug* Let GNU patch choke on it then. |
11 |
|
12 |
>> > +\ELSIF{any parameter beginning with a hyphen follows one that does not begin with a hyphen} |
13 |
>> > + \STATE abort the build process with an error |
14 |
>> |
15 |
>> I suggest "return immediately with an error" here, for consistency |
16 |
>> with the wording below. |
17 |
|
18 |
> Well, I wanted to emphasize difference in error handling. patch |
19 |
> failing implies error exit with respect to nonfatal. Usage error is |
20 |
> unconditional die. |
21 |
|
22 |
I see, but then the wording might be more explicit. Maybe instead of |
23 |
"If it fails" say "If applying the patches fails" in the description? |
24 |
|
25 |
Ulrich |