Gentoo Archives: gentoo-pms

From: Ulrich Mueller <ulm@g.o>
To: "Michał Górny" <mgorny@g.o>
Cc: gentoo-pms@l.g.o
Subject: Re: [gentoo-pms] Re: [PATCH v2] Explain eapply behavior for EAPI 6
Date: Wed, 14 Oct 2015 20:10:48
Message-Id: 22046.46782.755015.577902@a1i15.kph.uni-mainz.de
In Reply to: Re: [gentoo-pms] Re: [PATCH v2] Explain eapply behavior for EAPI 6 by "Michał Górny"
1 >>>>> On Wed, 14 Oct 2015, Michał Górny wrote:
2
3 >> Hm, I previously had "IF the first parameter begins with a hyphen
4 >> AND any parameter is equal to --", because the first parameter
5 >> certainly cannot be an option argument.
6
7 > I know. But does it really make a difference in our case? I wanted
8 > to try to make the algorithm a little simpler.
9
10 *shrug* Let GNU patch choke on it then.
11
12 >> > +\ELSIF{any parameter beginning with a hyphen follows one that does not begin with a hyphen}
13 >> > + \STATE abort the build process with an error
14 >>
15 >> I suggest "return immediately with an error" here, for consistency
16 >> with the wording below.
17
18 > Well, I wanted to emphasize difference in error handling. patch
19 > failing implies error exit with respect to nonfatal. Usage error is
20 > unconditional die.
21
22 I see, but then the wording might be more explicit. Maybe instead of
23 "If it fails" say "If applying the patches fails" in the description?
24
25 Ulrich

Replies

Subject Author
Re: [gentoo-pms] Re: [PATCH v2] Explain eapply behavior for EAPI 6 "Michał Górny" <mgorny@g.o>