1 |
>>>>> On Mon, 20 Dec 2010, Christian Faulhammer wrote: |
2 |
|
3 |
> Should I merge all patches in one or feature by feature? |
4 |
|
5 |
I would commit everything at once, but I think that's really up to |
6 |
you. |
7 |
|
8 |
> Please review, they might have some rough edges still. |
9 |
|
10 |
Thank you for all the work. See below for my comments. |
11 |
|
12 |
>> \t{S} to \t{WORKDIR} fallback restricted |
13 |
|
14 |
> I fail to find a short description of the exact exceptions, so for |
15 |
> now it just says: Fall back not there. How likely is it to hit the |
16 |
> exception? |
17 |
|
18 |
The conditions for an exception are described in subsection "Initial |
19 |
Working Directories". All of these must be true: |
20 |
|
21 |
* The A variable contains no items. |
22 |
* The phase function in question is not in DEFINED_PHASES. |
23 |
* None of the phase functions unpack, prepare, configure, compile or |
24 |
install, if supported by the EAPI in question and occurring prior |
25 |
to the phase about to be executed, are in DEFINED_PHASES. |
26 |
|
27 |
It more or less means "this is a virtual package". |
28 |
|
29 |
> Subject: [PATCH 03/10] EAPI Cheat Sheet: Add PROPERTIES |
30 |
> [...] |
31 |
> + \item[\code{PROPERTIES}] Is allowed for all package managers now |
32 |
> + to support interactive installs. |
33 |
|
34 |
It's allowed already now (in all EAPIs), but in EAPI 4 support for |
35 |
PROPERTIES is mandatory. |
36 |
|
37 |
> Subject: [PATCH 07/10] EAPI Cheat Sheet: Describe MERGE_TYPE |
38 |
> variable |
39 |
> [...] |
40 |
> + \item[MERGE\_TYPE] This variable contains one of three possible |
41 |
> + values to allow checks for the purpose of the current run: |
42 |
> + \begin{description} |
43 |
> + \item[\code{source}] Building and installing a package from |
44 |
> + source. |
45 |
> + \item[\code{binary}] Installing a binary package. |
46 |
> + \item[\code{buildonly}] Building a binary package without installing it. |
47 |
> + \end{description} |
48 |
> + See \featureref{merge-type}. |
49 |
|
50 |
This is a little long, but it's a matter of taste of course. |
51 |
|
52 |
> Subject: [PATCH 09/10] EAPI Cheat Sheet: Describe REQUIRED_USE and pkg_required_use |
53 |
> [...] |
54 |
> + \item[\code{REQUIRED\_USE}] This variable can be used similar to |
55 |
> + the \code{(R|P)DEPEND} variables and define sets of USE flag |
56 |
> + combinations that are not allowed. All elements can be further |
57 |
> + nested to achieve more functionality. |
58 |
> + \begin{description} |
59 |
> + \item[Forbidden combination] To prevent activation of |
60 |
> + \code{flag1} if \code{flag2} is enabled use "\code{flag2? ( |
61 |
> + !flag1 )}". |
62 |
> + \item[OR] If at least one USE flag out of many must be |
63 |
> + activated on \code{flag1} use "\code{flag1? || ( flag2 flag3 |
64 |
> + \dots )}". |
65 |
> + \item[XOR] To allow exactly one USE flag out of many use |
66 |
> + "\code{\textasciicircum\textasciicircum ( flag1 flag2 \dots )}". |
67 |
> + \end{description} |
68 |
> + If those restrictions are violated by the user settings the |
69 |
> + \code{pkg\_required\_use} function is run, where advise can be |
70 |
> + given to the user how to set USE flags. See |
71 |
> + \featureref{required-use}. |
72 |
|
73 |
The pkg_required_use function was rejected by the council, so the |
74 |
sentence immediately after the description list should be deleted. |
75 |
|
76 |
BTW, I had the same problem as above, that neither \t{^^} nor \t{\^\^} |
77 |
work in LaTeX. Does anybody know a shorter solution than |
78 |
\t{\textasciicircum\textasciicircum}? |
79 |
|
80 |
Ulrich |