Gentoo Archives: gentoo-pms

From: "Michał Górny" <mgorny@g.o>
To: gentoo-pms@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: [gentoo-pms] [PATCH 22/28] EAPI 7 bans dolib and libopts.
Date: Wed, 04 Oct 2017 20:48:01
Message-Id: 20171004204712.10391-23-mgorny@gentoo.org
In Reply to: [gentoo-pms] [PATCHES] EAPI 7, first draft for review by "Michał Górny"
1 Bug: https://bugs.gentoo.org/630416
2 ---
3 eapi-differences.tex | 7 +++++++
4 pkg-mgr-commands.tex | 22 ++++++++++++++--------
5 2 files changed, 21 insertions(+), 8 deletions(-)
6
7 diff --git a/eapi-differences.tex b/eapi-differences.tex
8 index d9b5558..70eadb5 100644
9 --- a/eapi-differences.tex
10 +++ b/eapi-differences.tex
11 @@ -224,6 +224,12 @@ Most utilities die & \compactfeatureref{die-on-failure} &
12 \t{dohtml} & \compactfeatureref{banned-commands} &
13 Yes & Yes & Yes & Yes & Banned \\
14
15 +\t{dolib} & \compactfeatureref{banned-commands} &
16 + Yes & Yes & Yes & Yes & Banned \\
17 +
18 +\t{libopts} & \compactfeatureref{banned-commands} &
19 + Yes & Yes & Yes & Yes & Banned \\
20 +
21 PM query options & \compactfeatureref{pm-query-options} &
22 No & No & \t{-{}-host-root} & \t{-{}-host-root} & \t{-b}, \t{-d}, \t{-r} \\
23
24 @@ -447,6 +453,7 @@ EAPI 7 is EAPI 6 with the following changes:
25 \item \t{PORTDIR} removed, \featureref{portdir}.
26 \item \t{ECLASSDIR} removed, \featureref{eclassdir}.
27 \item \t{domo} installs to \t{/usr/share/locale}, ignoring \t{into}, \featureref{domo-path}.
28 +\item \t{dolib} and \t{libopts} banned, \featureref{banned-commands}.
29 \end{compactitem}
30
31 \ChangeWhenAddingAnEAPI{7}
32 diff --git a/pkg-mgr-commands.tex b/pkg-mgr-commands.tex
33 index ae9a615..f3849fc 100644
34 --- a/pkg-mgr-commands.tex
35 +++ b/pkg-mgr-commands.tex
36 @@ -50,20 +50,22 @@ called, the package manager must abort the build process indicating an error.
37 \ChangeWhenAddingAnEAPI{7}
38 \begin{centertable}{Banned commands}
39 \label{tab:banned-commands-table}
40 - \begin{tabular}{lllll}
41 + \begin{tabular}{lllllll}
42 \toprule
43 \multicolumn{1}{c}{\textbf{EAPI}} &
44 - \multicolumn{4}{c}{\textbf{Command banned?}} \\
45 + \multicolumn{6}{c}{\textbf{Command banned?}} \\
46 \multicolumn{1}{c}{} &
47 \multicolumn{1}{c}{\textbf{\t{dohard}}} &
48 \multicolumn{1}{c}{\textbf{\t{dosed}}} &
49 \multicolumn{1}{c}{\textbf{\t{einstall}}} &
50 - \multicolumn{1}{c}{\textbf{\t{dohtml}}} \\
51 + \multicolumn{1}{c}{\textbf{\t{dohtml}}} &
52 + \multicolumn{1}{c}{\textbf{\t{dolib}}} &
53 + \multicolumn{1}{c}{\textbf{\t{libopts}}} \\
54 \midrule
55 - 0, 1, 2, 3 & No & No & No & No \\
56 - 4, 5 & Yes & Yes & No & No \\
57 - 6 & Yes & Yes & Yes & No \\
58 - 7 & Yes & Yes & Yes & Yes \\
59 + 0, 1, 2, 3 & No & No & No & No & No & No \\
60 + 4, 5 & Yes & Yes & No & No & No & No \\
61 + 6 & Yes & Yes & Yes & No & No & No \\
62 + 7 & Yes & Yes & Yes & Yes & Yes & Yes \\
63 \bottomrule
64 \end{tabular}
65 \end{centertable}
66 @@ -503,7 +505,9 @@ can be extended or reduced (see below). The options that can be passed to \t{doh
67 \item[dolib.so] As for \t{dolib.a} except each file is installed with mode \t{0755}.
68
69 \item[dolib] As for \t{dolib.a} except that the default install mode can be overriden with
70 - the \t{install} options set by the most recent \t{libopts} call.
71 + the \t{install} options set by the most recent \t{libopts} call. In EAPIs listed
72 + in table~\ref{tab:banned-commands-table}, this command is banned as per
73 + section~\ref{sec:banned-commands}.
74
75 \begin{algorithm}
76 \caption{Determining the library directory} \label{alg:ebuild-libdir}
77 @@ -714,6 +718,8 @@ has returned.
78 \item[exeopts] Sets the options passed by \t{doexe} et al.\ to the \t{install} command.
79
80 \item[libopts] Sets the options passed by \t{dolib} et al.\ to the \t{install} command.
81 + In EAPIs listed in table~\ref{tab:banned-commands-table}, this command is banned as
82 + per section~\ref{sec:banned-commands}.
83
84 \end{description}
85
86 --
87 2.14.2