Gentoo Archives: gentoo-pms

From: Ciaran McCreesh <ciaran.mccreesh@××××××××××.com>
To: Patrick Lauer <patrick@g.o>
Cc: gentoo-pms@l.g.o
Subject: Re: [gentoo-pms] tree-layout.tex small cleanup
Date: Sat, 19 Sep 2009 20:45:23
Message-Id: 20090919214515.6b314a3f@snowmobile
In Reply to: Re: [gentoo-pms] tree-layout.tex small cleanup by Patrick Lauer
1 On Sat, 19 Sep 2009 22:34:39 +0200
2 > > > Three small edits.
3 > > >
4 > > > - Removing a sentence that has no content, but spans three lines
5 > >
6 > > No, the two sentences you're removing both have meaning:
7 > >
8 > > The first says that it's ok for things to exist in
9 > > profiles/categories that don't have a directory
10 >
11 > Rationale for that?
12
13 People have done it in the past. It's also something that ends up
14 happening if categories are removed but people are syncing using
15 something that doesn't remove empty directories or directories that
16 still contain editor-created backup files lying around.
17
18 > > The second says that the package manager mustn't treat empty
19 > > categories and categories that don't exist differently.
20 > Not quite. What it says is that an empty and a non-existing category
21 > are equivalent, which doesn't explain how to treat them. Your current
22 > interpretation is already a large improvement.
23
24 The wording in PMS is sound, and says exactly what it needs to say. If
25 you'd like to propose clarifications to that wording that make it
26 easier to understand, feel free to do so, but the actual meaning
27 mustn't be changed.
28
29 > > Both are necessary.
30 >
31 > No, first one is confusing to read
32
33 How is it in any way confusing?
34
35 >, second one is a tautology.
36
37 It's not. It would be quite possible to write an implementation that
38 treats categories that don't exist as an error rather than an empty
39 category. We have to forbid such an implementation.
40
41 > > > - Simplifying the ebuild naming - since suffix is always "ebuild"
42 > > > there is no need to use an indirection
43 > > >
44 > > > - Fixing the list because "suffix is ebuild" now is redundant
45 > >
46 > > Uhm. That part of the patch doesn't apply, and the revision against
47 > > which you're basing it isn't in the repository. Where did you get
48 > > 'b78fde2' from?
49 > >
50 > Oh. I have over 900 lines diff already. Just pulling out the obvious
51 > changes before moving on to the more subjective and debatable ones.
52
53 If that 900 line diff is 'drop kdebuild', I suggest you don't bother. In
54 any case, please learn how to use 'git rebase' and only send patches
55 that are against current master -- even for patches that do apply, if
56 you're basing them upon unpublished changes, we can't use three way
57 merges when applying them.
58
59 --
60 Ciaran McCreesh

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-pms] tree-layout.tex small cleanup Patrick Lauer <patrick@g.o>
Re: [gentoo-pms] tree-layout.tex small cleanup Ulrich Mueller <ulm@g.o>