| 1 |
On Mon, 7 May 2012 02:12:14 +0200 |
| 2 |
Ulrich Mueller <ulm@g.o> wrote: |
| 3 |
> | Furthermore, for these EAPIs, if the function is overridden, it |
| 4 |
> | shall be a fatal error if the apply_user_patches command has not |
| 5 |
> | been called at least once by the end of the phase. |
| 6 |
> |
| 7 |
> Wouldn't it make more sense to call apply_user_patches implicitly at |
| 8 |
> the end of the phase, if it hasn't been called before? |
| 9 |
> |
| 10 |
> Otherwise, a call to that function would have to be added to every |
| 11 |
> ebuild that defines src_prepare. |
| 12 |
|
| 13 |
That was the point. The discussion on gentoo-dev suggested that "at the |
| 14 |
end" is often the wrong place to put it, due to eautoreconf etc. We |
| 15 |
need people to be explicit about where it goes. |
| 16 |
|
| 17 |
-- |
| 18 |
Ciaran McCreesh |
Archives