Re: [gentoo-pms] [PATCH] ebuild-vars: Remove 'simple filename' mirror fetching

[Ulrich Mueller]

>>>>> On Sun, 22 Dec 2019, Michał Górny wrote:

> --- a/appendices.tex
> +++ b/appendices.tex

Hm, we list retroactive fixes in the appendix only if we go through
Council approval. I wonder if we need it for this, when the
functionality was never actually used?

> @@ -110,6 +110,13 @@ all-of, any-of, exactly-one-of, at-most-one-of and use-conditional groups with z
>  However, such empty groups were neither supported by all package managers nor used in ebuilds.
>  They were dropped from the specification in October 2017.
>
> +\subsection{Simple filename in SRC\_URI}

No backslash before the underscore please, it will break grepping for
SRC_URI.

> +The SRC\_URI format (see section~\ref{sec:src-uri-behaviour}) originally permitted using a simple
> +filename instead of a full URI to indicate a~file that can be fetched from mirrors only.
> +However, the Portage implementation worked only if the user had configured mirrors explicitly,
> +and it was not used in ebuilds.  This feature has been dropped in December 2019, limiting simple

Nitpick, please use a single space after the full stop, for consistency
throughout the document.

> +filename usage to fetch-restricted packages.
> +
>  % vim: set filetype=tex fileencoding=utf8 et tw=100 spell spelllang=en :
>
>  %%% Local Variables:

> --- a/ebuild-vars.tex
> +++ b/ebuild-vars.tex
> @@ -159,11 +159,9 @@ managers may also consult mirrors for their files.
>  The special \t{mirror://} protocol must be supported. See section~\ref{sec:thirdpartymirrors} for
>  mirror details.
>
> -If a simple filename rather than a full URI is provided, the package manager can only use mirrors
> -to download the file.
> -
>  The \t{RESTRICT} metadata key can be used to impose additional restrictions upon downloading---see
> -section~\ref{sec:restrict} for details.
> +section~\ref{sec:restrict} for details.  If a fetch restriction is used, a simple filename can
> +be used in lieu of full URI.

"Lieu"? Merriam-Webster labels this as archaic. Also usage of the
indefinite articles in that sentence is a little odd.

Suggestion: "Fetch restricted packages may use a simple filename instead
of a full URI."

>
>  \featurelabel{src-uri-arrows} In EAPIs listed in table~\ref{tab:uri-arrows-table} as supporting
>  arrows, if an arrow is used, the filename used when saving to \t{DISTDIR} shall instead be the name

Ulrich