Re: [gentoo-pms] [PATCH] ebuild-env-vars: Allow FILESDIR to be a shadow directory

[Ulrich Mueller]

>>>>> On Thu, 16 Mar 2017, Michał Górny wrote:

> On czw, 2017-03-16 at 21:58 +0100, Ulrich Mueller wrote:
>> I wonder if the "Consistent?" column should be changed to "Yes",
>> too? Ebuilds rely on the FILESDIR variable having the same value
>> in the src_* phases as it had in global scope. Same for DISTDIR.

> Speaking implementation-wise, yes, FILESDIR is now guaranteed to be
> consistent. However, FWICS Portage changes DISTDIR between original
> path and shadow path.

Following discussion in #gentoo-pms, I think we should leave the
"Consistent" column alone. Things will still work if these variables
(e.g. DISTDIR) point to the real dir in global scope but to a shadow
dir in src_* phases.

So IMO the original patch is just fine.

Ulrich