Re: [gentoo-pms] Re: [PATCH] Explain eapply behavior for EAPI 6

[Ulrich Mueller]

>>>>> On Wed, 14 Oct 2015, Michał Górny wrote:

>> IF first parameter begins with a hyphen AND any parameter is equal to --

> Hmm, that's not exactly correct. All parameters preceding -- would have
> to begin with a hyphen. So maybe...

>       IF any parameter is equal to -- AND all parameters preceding it
>         being with a hyphen

Well, there could be option arguments, too. And we don't know which
patch options can have arguments, unless we copy the option parsing
from patch(1) which is not feasible.

My wording was like this on purpose, and the idea is that if the
ebuild author has specified an explicit -- separator, then we assume
the he knows what he is doing. So we pass the whole part before the --
as options (plus possibly option arguments) to patch.

>> collect all parameters before the first -- in the options array
>> collect all parameters after the first -- in the files array
>> ELSIF any parameter beginning with a hyphen follows one without a hyphen
>> return an error

> Not sure if we should really specify error handling here. The idea is
> that this is incorrect syntax, so it is unconditional fatal error.

Sure, s/return an error/abort the build process/

>> ELSE
>> collect all parameters starting with a hyphen in the options array
>> collect all parameters without a hyphen in the files array
>> ENDIF

>> patch -p1 -f -g0 --no-backup-if-mismatch

> Ok.

Good. :)

>> We should say something about error handling. For example, does the
>> function return when it encounters the first error of a called
>> patch(1)?

> Where should I say it? Put in the algorithm?

Not sure, error exits tend to be clumsy. Does the algorithmic package
include a GOTO statement? :) To be serious, maybe it's best to leave
it out of the algorithm for better clarity, and put it into the
description instead.

What about nonfatal, BTW? We should be consistent with other commands
there.

Ulrich