[gentoo-pms] [PATCH] src-install-4: Check for empty DOCS variable.

[Ulrich Mueller]

This arises from bug 481664. There seems to be consensus that the
default src_install function of EAPI 4 (and 5) is flawed, because it
cannot handle the case where an ebuild specifies DOCS="" or DOCS=().
The question is whether we wait with a fix until EAPI 6, or if we
change it retroactively.

See https://bugs.gentoo.org/show_bug.cgi?id=481664#c29 and following
(in particular, comment 37) for a discussion of the issue. It looks
like no ebuild is currently affected by this.

Ulrich


From c865af98e08f721383b1ece2a6f310794662d3f6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ulrich=20M=C3=BCller?= <ulm@g.o>
Date: Thu, 22 Aug 2013 12:38:02 +0200
Subject: [PATCH] src-install-4: Check for empty DOCS variable.

---
 ebuild-functions.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ebuild-functions.tex b/ebuild-functions.tex
index 84847e9..46e6f3b 100644
--- a/ebuild-functions.tex
+++ b/ebuild-functions.tex
@@ -318,9 +318,9 @@ src_install() {
             [[ -s "${d}" ]] && dodoc "${d}"
         done
     elif declare -p DOCS | grep -q "^declare -a " ; then
-        dodoc "${DOCS[@]}"
+        [[ ${DOCS[@]} ]] && dodoc "${DOCS[@]}"
     else
-        dodoc ${DOCS}
+        [[ ${DOCS} ]] && dodoc ${DOCS}
     fi
 }
 \end{verbatim}
-- 
1.8.3.2