Archives
Archives
| From: | Ulrich Mueller <ulm@g.o> | ||
|---|---|---|---|
| To: | gentoo-pms@l.g.o | ||
| Cc: | "Michał Górny" <mgorny@g.o> | ||
| Subject: | Re: [gentoo-pms] [PATCH] ebuild-env-vars: Require DISTDIR & FILESDIR to be consistent | ||
| Date: | Sat, 18 Mar 2017 07:33:20 | ||
| Message-Id: | 22732.58024.391007.724863@a1i15.kph.uni-mainz.de | ||
| In Reply to: | [gentoo-pms] [PATCH] ebuild-env-vars: Require DISTDIR & FILESDIR to be consistent by "Michał Górny" |
||
| 1 | >>>>> On Sat, 18 Mar 2017, Michał Górny wrote: |
| 2 | |
| 3 | > Require both DISTDIR and FILESDIR variables to have consistent value |
| 4 | > across phases. We need to guarantee that the value used in global scope |
| 5 | > to propagate PATCHES array will be still valid in src_prepare(). |
| 6 | > Furthermore, as Ulrich Müller points out that PMS requires ebuilds to |
| 7 | > recalculate any value derived from inconsistent variables, therefore |
| 8 | > colliding with the global-scope assignment. |
| 9 | |
| 10 | LGTM |