Re: [gentoo-pms] [PATCH v3] EAPI 6: Specify return status for eapply_user.

[Michał Górny]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512



Dnia 30 października 2015 09:17:49 CET, Ulrich Mueller <ulm@g.o> napisał(a):
>>>>>> On Thu, 29 Oct 2015, Ulrich Mueller wrote:
>
>> We have two successful states, so obviously (at least) one of them
>> must return shell false.
>
>This is the part which causes the problems. As discussed amongst
>council members, we are going to drop this. So, the command will
>return true for success and false for failure.
>
>If it should turn out that information about applied user's patches
>will be needed, a query function (that could even show a list of
>applied patches, like perl -V does) can be added later. This will be
>something for EAPI 7, though.

Sounds good to me. In fact, we can't really predict what user patches may change and what ebuild changes they may require. And we can't really expect every ebuild to account even for the most common changes.

>
>Patch v3 is below.
>
>Ulrich
>
>
>From cad46e884d84bacbd7763ea7cec69b59f5031acb Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Ulrich=20M=C3=BCller?= <ulm@g.o>
>Date: Fri, 30 Oct 2015 01:37:00 +0100
>Subject: [PATCH] EAPI 6: Specify return status for eapply_user.
>
>---
> pkg-mgr-commands.tex | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
>diff --git a/pkg-mgr-commands.tex b/pkg-mgr-commands.tex
>index 51f6ebf..b9d53bd 100644
>--- a/pkg-mgr-commands.tex
>+++ b/pkg-mgr-commands.tex
>@@ -157,10 +157,12 @@ Ebuilds must not run any of these commands once
>the current phase function has r
>\item[eapply\_user] \featurelabel{eapply-user} Takes no arguments.
>Package managers supporting it
>apply user-provided patches to the source tree in the current working
>directory. Exact behaviour
>is implementation defined and beyond the scope of this specification.
>Package managers not
>-    supporting it must implement the command as a no-op. Only
>available in EAPIs listed in
>-    table~\ref{tab:patch-commands} as supporting \t{eapply\_user}. In
>EAPIs where it is supported,
>-    \t{eapply\_user} must be called once in the \t{src\_prepare}
>phase; for any subsequent calls
>-    the command will do nothing.
>+    supporting it must implement the command as a no-op. Returns shell
>true (0) if patches applied
>+    successfully, or if no patches were provided. Otherwise, aborts
>the build process, unless run
>+    using \t{nonfatal}, in which case it returns non-zero exit status.
>Only available in EAPIs
>+    listed in table~\ref{tab:patch-commands} as supporting
>\t{eapply\_user}. In EAPIs where it is
>+    supported, \t{eapply\_user} must be called once in the
>\t{src\_prepare} phase; for any
>+    subsequent calls, the command will do nothing and return~0.
> \end{description}
>
> \begin{algorithm}

- --
Best regards,
Michał Górny
-----BEGIN PGP SIGNATURE-----

iQJJBAEBCgAzLBxNaWNoYcWCIEfDs3JueSAoR2VudG9vKSA8bWdvcm55QGdlbnRv
by5vcmc+BQJWMzIYAAoJELB6GurvtEZOQ5kP/2WEgAZH48/PuoLPbdH8fhfYwZXk
AitCVDzVlscN5hvrMxV49e0/UbvUFFQbWszwplH4BGjQ7GW2e2mBd+4IjzktkKiL
RT2YyCl8BdROaNQWx0cxZiC/VajvzEX7GAYgOV/GiBGb5671HU2ByjMlIJZkJafF
oqewZQh1yDhzMhsBMBO6COlJYkCvbUDnoghcqjshCDdIjJY7REvtAh9Ce9FvhGlF
IznytxM9/yXabk6am6TX7caU3eAiH/gYWV9T7q4owYSuiTix850gwxA4WcFh1uW7
45gncBKxSpqtcaagZVsZZOa8eL2Q67K3b+gWNZkPIYLUsDtYiDuSSDmkez0ALWRz
JBE0nAxcG1l1S81P5CsgeL1RejSMJTwjbrPJR1kjPMeSOTCueLMWjWY/2U3gR+wS
w4Q01mEsDH3I7Q4GUA2T10HagUeW1tv9bVLbwz6GrjZcj0hEQDYetijcGauiDjrB
6YG5gSNszRyhQqxeKdZ4Hc0kXjCdk8vt3/aK2pEYil8vBh+O+LlNqLB4VoviKT0x
EjUXBbXVq68FAY6FcdIK8sp57HquXsEPgCsx1p8PuR0s0x7YSbS1C6ztFFwF6v0d
XFbR0D8ePN0yReY9IqHu7lPEmhNcq8mZ/l83PIOeZsnz/T2fDo5i8WpSgseioD8j
m8pwHyHNhbg6lfTE
=1uvJ
-----END PGP SIGNATURE-----