[gentoo-pms] Re: [PATCH v2] EAPI 6: Specify return status for eapply_user.

[Ulrich Mueller]

>>>>> On Thu, 29 Oct 2015, Rich Freeman wrote:

> On Thu, Oct 29, 2015 at 4:28 AM, Ulrich Mueller <ulm@g.o> wrote:
>>
>> Also seems natural to return 0 in the most common case that there
>> are no user patches, and in the case that eapply_user() is a no-op.

> I think the no-op situation requires care.

By "no-op" I meant the case that the package manager would implement
the function as a no-op, which is allowed by the spec.

> The whole reason for having the no-op option is if it gets called in
> one or more eclasses and then in the ebuild itself.

> That would mean that it would become the responsibility of the
> eclass to re-autoconf the package if the patches apply.  As long as
> this is done I'm fine with the approach.  I suppose that makes
> sense, but I just want to make sure everybody is on the same page.
> Otherwise the patches apply in an eclass and then the ebuild gets
> the impression that no patches were applied.

That's a different situation, and I hope it will be taken care of by
the requirement that on subsequent calls to eapply_user the same
return status as before must be returned.

Ulrich