Gentoo Archives: gentoo-pms

From: Ulrich Mueller <ulm@g.o>
To: gentoo-pms@l.g.o
Cc: council@g.o
Subject: [gentoo-pms] [PATCH v3] EAPI 6: Specify return status for eapply_user.
Date: Fri, 30 Oct 2015 08:18:01
Message-Id: 22067.10157.358919.680292@a1i15.kph.uni-mainz.de
In Reply to: Re: [gentoo-pms] [PATCH v2] EAPI 6: Specify return status for eapply_user. by Ulrich Mueller
1 >>>>> On Thu, 29 Oct 2015, Ulrich Mueller wrote:
2
3 > We have two successful states, so obviously (at least) one of them
4 > must return shell false.
5
6 This is the part which causes the problems. As discussed amongst
7 council members, we are going to drop this. So, the command will
8 return true for success and false for failure.
9
10 If it should turn out that information about applied user's patches
11 will be needed, a query function (that could even show a list of
12 applied patches, like perl -V does) can be added later. This will be
13 something for EAPI 7, though.
14
15 Patch v3 is below.
16
17 Ulrich
18
19
20 From cad46e884d84bacbd7763ea7cec69b59f5031acb Mon Sep 17 00:00:00 2001
21 From: =?UTF-8?q?Ulrich=20M=C3=BCller?= <ulm@g.o>
22 Date: Fri, 30 Oct 2015 01:37:00 +0100
23 Subject: [PATCH] EAPI 6: Specify return status for eapply_user.
24
25 ---
26 pkg-mgr-commands.tex | 10 ++++++----
27 1 file changed, 6 insertions(+), 4 deletions(-)
28
29 diff --git a/pkg-mgr-commands.tex b/pkg-mgr-commands.tex
30 index 51f6ebf..b9d53bd 100644
31 --- a/pkg-mgr-commands.tex
32 +++ b/pkg-mgr-commands.tex
33 @@ -157,10 +157,12 @@ Ebuilds must not run any of these commands once the current phase function has r
34 \item[eapply\_user] \featurelabel{eapply-user} Takes no arguments. Package managers supporting it
35 apply user-provided patches to the source tree in the current working directory. Exact behaviour
36 is implementation defined and beyond the scope of this specification. Package managers not
37 - supporting it must implement the command as a no-op. Only available in EAPIs listed in
38 - table~\ref{tab:patch-commands} as supporting \t{eapply\_user}. In EAPIs where it is supported,
39 - \t{eapply\_user} must be called once in the \t{src\_prepare} phase; for any subsequent calls
40 - the command will do nothing.
41 + supporting it must implement the command as a no-op. Returns shell true (0) if patches applied
42 + successfully, or if no patches were provided. Otherwise, aborts the build process, unless run
43 + using \t{nonfatal}, in which case it returns non-zero exit status. Only available in EAPIs
44 + listed in table~\ref{tab:patch-commands} as supporting \t{eapply\_user}. In EAPIs where it is
45 + supported, \t{eapply\_user} must be called once in the \t{src\_prepare} phase; for any
46 + subsequent calls, the command will do nothing and return~0.
47 \end{description}
48
49 \begin{algorithm}
50 --
51 2.6.2

Replies