Gentoo Archives: gentoo-pms

From: Ulrich Mueller <ulm@g.o>
To: gentoo-pms@l.g.o
Cc: council@g.o
Subject: [gentoo-pms] [PATCH] EAPI 6: Specify return status for eapply_user.
Date: Wed, 28 Oct 2015 22:31:21
Message-Id: 22065.19633.293221.111159@a1i15.kph.uni-mainz.de
1 Hi all,
2
3 It is late in the EAPI 6 process, but I believe that the patch below
4 is a good change. We should specify a return status for eapply_user.
5
6 Please review.
7
8 Ulrich
9
10
11 From cb0ac7d5bc88d70be0b81e17a3fb6b5c34642b50 Mon Sep 17 00:00:00 2001
12 From: =?UTF-8?q?Ulrich=20M=C3=BCller?= <ulm@g.o>
13 Date: Wed, 28 Oct 2015 23:20:32 +0100
14 Subject: [PATCH] EAPI 6: Specify return status for eapply_user.
15
16 Suggested by dilfridge.
17 ---
18 pkg-mgr-commands.tex | 10 ++++++----
19 1 file changed, 6 insertions(+), 4 deletions(-)
20
21 diff --git a/pkg-mgr-commands.tex b/pkg-mgr-commands.tex
22 index 51f6ebf..b6164df 100644
23 --- a/pkg-mgr-commands.tex
24 +++ b/pkg-mgr-commands.tex
25 @@ -157,10 +157,12 @@ Ebuilds must not run any of these commands once the current phase function has r
26 \item[eapply\_user] \featurelabel{eapply-user} Takes no arguments. Package managers supporting it
27 apply user-provided patches to the source tree in the current working directory. Exact behaviour
28 is implementation defined and beyond the scope of this specification. Package managers not
29 - supporting it must implement the command as a no-op. Only available in EAPIs listed in
30 - table~\ref{tab:patch-commands} as supporting \t{eapply\_user}. In EAPIs where it is supported,
31 - \t{eapply\_user} must be called once in the \t{src\_prepare} phase; for any subsequent calls
32 - the command will do nothing.
33 + supporting it must implement the command as a no-op. Returns 0 if patches applied successfully,
34 + or 1 if no patches were applied. On failure, returns 2 when called using \t{nonfatal}, otherwise
35 + aborts the build process. Only available in EAPIs listed in table~\ref{tab:patch-commands} as
36 + supporting \t{eapply\_user}. In EAPIs where it is supported, \t{eapply\_user} must be called
37 + once in the \t{src\_prepare} phase; for any subsequent calls the command will do nothing, and
38 + it will return the same status as for the first call.
39 \end{description}
40
41 \begin{algorithm}
42 --
43 2.6.2

Replies