Gentoo Archives: gentoo-pms

From: Ulrich Mueller <ulm@g.o>
To: gentoo-pms@l.g.o
Cc: council@g.o
Subject: [gentoo-pms] [PATCH] Installation commands must be called with at least one parameter.
Date: Tue, 20 Aug 2013 12:49:57
Message-Id: 21011.26091.873791.416804@a1i15.kph.uni-mainz.de
1 The wording of PMS is somewhat unclear here. However, doins and
2 friends are implemented in all package managers with a check for at
3 least one parameter. The patch included below clarifies this.
4 See also <https://bugs.gentoo.org/show_bug.cgi?id=481664#c15>.
5
6 CCing council on this one.
7
8 Ulrich
9
10
11 From 24f1da1fec863f1497007985751853c4e7501f50 Mon Sep 17 00:00:00 2001
12 From: =?UTF-8?q?Ulrich=20M=C3=BCller?= <ulm@g.o>
13 Date: Tue, 20 Aug 2013 14:40:41 +0200
14 Subject: [PATCH] Installation commands must be called with at least one
15 parameter.
16
17 Also adjust the wording for doinfo, doman, and domo, in order to
18 clarify that multiple file name parameters are allowed.
19 ---
20 pkg-mgr-commands.tex | 23 ++++++++++++-----------
21 1 file changed, 12 insertions(+), 11 deletions(-)
22
23 diff --git a/pkg-mgr-commands.tex b/pkg-mgr-commands.tex
24 index bafa748..bcd254d 100644
25 --- a/pkg-mgr-commands.tex
26 +++ b/pkg-mgr-commands.tex
27 @@ -249,8 +249,9 @@ install} target cannot be used or does not install all needed files. Except wher
28 all filenames created or modified are relative to the staging directory including the offset-prefix
29 \t{ED} in offset-prefix aware EAPIs, or just the staging directory \t{D} in offset-prefix agnostic
30 EAPIs. Existing destination files are overwritten. These commands must all be external programs and
31 -not bash functions or aliases---that is, they must be callable from \t{xargs}. Ebuilds must not run
32 -any of these commands once the current phase function has returned.
33 +not bash functions or aliases---that is, they must be callable from \t{xargs}. Calling any of these
34 +commands without a parameter is an error. Ebuilds must not run any of these commands once the
35 +current phase function has returned.
36
37 \begin{description}
38 \item[dobin] Installs the given files into \t{DESTTREE/bin}, where
39 @@ -320,8 +321,8 @@ can be extended or reduced (see below). The options that can be passed to \t{doh
40 It is undefined whether a failure shall occur if \t{-r} is not specified and a directory is
41 encountered. Ebuilds must not rely upon any particular behaviour.
42
43 -\item[doinfo] Installs a GNU Info file into the \t{/usr/share/info} area with file mode \t{0644}.
44 - Failure behaviour is EAPI dependent as per section~\ref{sec:failure-behaviour}.
45 +\item[doinfo] Installs the given GNU Info files into the \t{/usr/share/info} area with file mode
46 + \t{0644}. Failure behaviour is EAPI dependent as per section~\ref{sec:failure-behaviour}.
47
48 \item[doinitd] Installs the given initscript files into \t{/etc/init.d}, by default with file mode
49 \t{0755}. This can be overridden by setting \t{EXEOPTIONS} with the \t{exeopts} function.
50 @@ -367,9 +368,9 @@ can be extended or reduced (see below). The options that can be passed to \t{doh
51 \end{algorithmic}
52 \end{algorithm}
53
54 -\item[doman] Installs a man page into the appropriate subdirectory of \t{/usr/share/man} depending
55 - upon its apparent section suffix (e.\,g.\ \t{foo.1} goes to \t{/usr/share/man/man1/foo.1}) with
56 - file mode \t{0644}.
57 +\item[doman] Installs the given man pages into the appropriate subdirectory of \t{/usr/share/man}
58 + depending upon its apparent section suffix (e.\,g.\ \t{foo.1} goes to
59 + \t{/usr/share/man/man1/foo.1}) with file mode \t{0644}.
60
61 \featurelabel{doman-langs} In EAPIs listed in table~\ref{tab:doman-table} as supporting
62 language detection by filename, a man page with name of the form \t{foo.}\i{lang}\t{.1} shall
63 @@ -383,10 +384,10 @@ can be extended or reduced (see below). The options that can be passed to \t{doh
64 the empty string. In EAPIs specified by table~\ref{tab:doman-table}, the \t{-i18n} option takes
65 precedence over the language code in the filename.
66
67 -\item[domo] Installs a \t{.mo} file with file mode \t{0644} into the appropriate subdirectory of
68 - \t{DESTTREE\slash share\slash locale}, generated by taking the basename of the file, removing
69 - the \t{.*} suffix, and appending \t{/LC\_MESSAGES}. The name of the installed files is the
70 - package name with \t{.mo} appended. Failure behaviour is EAPI dependent as per
71 +\item[domo] Installs the given \t{.mo} files with file mode \t{0644} into the appropriate
72 + subdirectory of \t{DESTTREE\slash share\slash locale}, generated by taking the basename of the
73 + file, removing the \t{.*} suffix, and appending \t{/LC\_MESSAGES}. The name of the installed
74 + files is the package name with \t{.mo} appended. Failure behaviour is EAPI dependent as per
75 section~\ref{sec:failure-behaviour}.
76
77 \item[dosbin] As \t{dobin}, but installs to \t{DESTTREE/sbin}.
78 --
79 1.8.3.2

Replies