Gentoo Archives: gentoo-pms

From: Christian Faulhammer <fauli@g.o>
To: Ciaran McCreesh <ciaran.mccreesh@××××××××××.com>
Cc: gentoo-pms@l.g.o
Subject: Re: [gentoo-pms] Patches for your reviewing pleasure: Various improvements, including cheat sheet
Date: Wed, 15 Apr 2009 22:46:24
Message-Id: 20090416004607.549bde01@terra.solaris
In Reply to: Re: [gentoo-pms] Patches for your reviewing pleasure: Various improvements, including cheat sheet by Ciaran McCreesh
1 Hi,
2
3 Ciaran McCreesh <ciaran.mccreesh@××××××××××.com>:
4 > s/label/labels/, and s/built/which can be built/
5 ..
6 > A use flag, not an.
7 ..
8 > That '.' should be a ','. I'd also say "so any small" rather than "so
9 > small".
10
11 Addressed.
12
13 > > 0004: Comment class file
14 >
15 > Some of the lines in this one have trailing whitespace. Git moans
16 > about this, and it looks horrible. Can you get your editor to show
17 > you these so they don't slip through?
18
19 I thought I had that activated...I was wrong.
20
21 0001: Desk reference anew, even with TOC entry now
22 0002: Makefile tweaking
23 0003: Gentoo logo addition for playing around
24
25 V-Li
26
27 --
28 Christian Faulhammer, Gentoo Lisp project
29 <URL:http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode
30
31 <URL:http://gentoo.faulhammer.org/>

Attachments

File name MIME type
0001-Desk-reference-for-quick-look-up.patch text/x-patch
0002-Tweak-Makefile-with-additional-dependency-on-targets.patch text/x-patch
0003-Add-Gentoo-logo-to-desk-reference-and-titlepage-of-P.patch text/x-patch
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-pms] Patches for your reviewing pleasure: Various improvements, including cheat sheet Ciaran McCreesh <ciaran.mccreesh@××××××××××.com>