Archives
Archives
| From: | Ulrich Mueller <ulm@g.o> | ||
|---|---|---|---|
| To: | gentoo-pms@l.g.o | ||
| Subject: | [gentoo-pms] Re: [PATCH] WORKDIR has same scope as FILESDIR and DISTDIR. | ||
| Date: | Tue, 11 Apr 2017 17:44:30 | ||
| Message-Id: | 22765.5622.179749.186123@a1i15.kph.uni-mainz.de | ||
| In Reply to: | [gentoo-pms] Re: [PATCH] WORKDIR has same scope as FILESDIR and DISTDIR. by Ulrich Mueller |
||
| 1 | >>>>> On Sat, 18 Mar 2017, Ulrich Mueller wrote: |
| 2 | |
| 3 | >> As pointed out by mgorny [1], S really has the same scope as WORKDIR. |
| 4 | >> Updated patch below. |
| 5 | |
| 6 | >> [1] https://bugs.gentoo.org/613110 |
| 7 | |
| 8 | Reverted [2] and applied my original patch [3] which affects only |
| 9 | WORKDIR (i.e. no change for the S variable). |
| 10 | |
| 11 | Rationale: Allowing S in global scope leads to other issues. |
| 12 | Especially, restrictions for global variables [4] will apply, so |
| 13 | ebuilds cannot rely on the variable's value in global scope (unless |
| 14 | they have explicitly assigned it before). |
| 15 | |
| 16 | Ulrich |
| 17 | |
| 18 | [2] https://gitweb.gentoo.org/proj/pms.git/commit/?id=7a04d1e8577ec052e8309b1daf1d96ddeea40fa7 |
| 19 | [3] https://gitweb.gentoo.org/proj/pms.git/commit/?id=f2ac6d06fae4923d0c913f9aa84452920e06ddb9 |
| 20 | [4] https://projects.gentoo.org/pms/6/pms.html#x1-12200011.2 |