| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA256 |
| 3 |
|
| 4 |
These look good. ACK on 1 and 2 from me, but I would like Sebastian, |
| 5 |
Arfrever, Brian, or someone else at least to look over them. These |
| 6 |
patches are too "interesting" to be pushed after a single ACK. |
| 7 |
|
| 8 |
For 3, I think it looks nice but you should check with Brian & Tom |
| 9 |
about whether to put it in now or in the refactor branch. Also, please |
| 10 |
ask QA about it so we don't get another bikeshed marathon to deal with. |
| 11 |
|
| 12 |
|
| 13 |
Lastly, I think the commit message of the first commit is very poorly |
| 14 |
worded, but we've discussed that on IRC. Ping me there for more |
| 15 |
details if you want. |
| 16 |
|
| 17 |
|
| 18 |
Thanks for doing this! |
| 19 |
- -- |
| 20 |
Alexander |
| 21 |
bernalex@g.o |
| 22 |
https://secure.plaimi.net/~alexander |
| 23 |
-----BEGIN PGP SIGNATURE----- |
| 24 |
Version: GnuPG v2 |
| 25 |
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ |
| 26 |
|
| 27 |
iF4EAREIAAYFAlPr1B4ACgkQRtClrXBQc7VG7gEAllXiY0FUKn+5dUajk/tiZoj/ |
| 28 |
3H3KW9MPfmfeMh0Dnv8BAJX+y8hsBnppm9W+ap8VfzkrxGeme6J6VSAdYCQd+Dea |
| 29 |
=VX87 |
| 30 |
-----END PGP SIGNATURE----- |
Archives