Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] repoman: make unused local USE flags an error
Date: Fri, 06 Jan 2017 17:20:44
Message-Id: 20170106092040.118e4c4e.dolsen@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH] repoman: make unused local USE flags an error by Brian Dolbec
1 On Wed, 4 Jan 2017 14:29:01 -0800
2 Brian Dolbec <dolsen@g.o> wrote:
3
4 > On Wed, 4 Jan 2017 13:14:38 -0500
5 > Mike Gilbert <floppym@g.o> wrote:
6 >
7 > > X-Gentoo-Bug: 602002
8 > > X-Gentoo-Bug-URL: https://bugs.gentoo.org/602002
9 > > ---
10 > > repoman/pym/repoman/modules/scan/metadata/pkgmetadata.py | 2 +-
11 > > 1 file changed, 1 insertion(+), 1 deletion(-)
12 > >
13 > > diff --git
14 > > a/repoman/pym/repoman/modules/scan/metadata/pkgmetadata.py
15 > > b/repoman/pym/repoman/modules/scan/metadata/pkgmetadata.py index
16 > > 9e4d6cb93..92c74e6f8 100644 ---
17 > > a/repoman/pym/repoman/modules/scan/metadata/pkgmetadata.py +++
18 > > b/repoman/pym/repoman/modules/scan/metadata/pkgmetadata.py @@
19 > > -166,7 +166,7 @@ class PkgMetadata(ScanBase, USEFlagChecks): if
20 > > valid_state: for myflag in
21 > > self.muselist.difference(self.usedUseFlags):
22 > > self.qatracker.add_error(
23 > > - "metadata.warning",
24 > > + "metadata.bad",
25 > > "%s/metadata.xml: unused
26 > > local USE-description: '%s'" % (xpkg, myflag))
27 > > return False
28 >
29 >
30 > Thanks, looks good.
31
32 merged :)
33
34 Thanks
35 --
36 Brian Dolbec <dolsen>