Archives
Archives
| From: | Zac Medico <zmedico@g.o> | ||
|---|---|---|---|
| To: | gentoo-portage-dev@l.g.o, Pin-yen Lin <treapking@××××××××.org> | ||
| Subject: | Re: [gentoo-portage-dev] [PATCH 2/2] Add caching to _slot_operator_check_reverse_dependencies | ||
| Date: | Mon, 28 Nov 2022 15:47:28 | ||
| Message-Id: | 7d39c5e2-c08f-f7e9-31a0-9c6979d31428@gentoo.org | ||
| In Reply to: | [gentoo-portage-dev] [PATCH 2/2] Add caching to _slot_operator_check_reverse_dependencies by Pin-yen Lin |
||
| 1 | On 11/24/22 19:36, Pin-yen Lin wrote: |
| 2 | > Add lru_cache to speed up the running time of "Calculating |
| 3 | > dependencies". |
| 4 | > |
| 5 | > In a ChromeOS use case, this patch decreases the running time from |
| 6 | > 311s to 197s with almost no memory usage increase. |
| 7 | > |
| 8 | > Signed-off-by: Pin-yen Lin <treapking@××××××××.org> |
| 9 | > --- |
| 10 | > lib/_emerge/depgraph.py | 1 + |
| 11 | > 1 file changed, 1 insertion(+) |
| 12 | > |
| 13 | > diff --git a/lib/_emerge/depgraph.py b/lib/_emerge/depgraph.py |
| 14 | > index ce6cabcc1..9649bb2a8 100644 |
| 15 | > --- a/lib/_emerge/depgraph.py |
| 16 | > +++ b/lib/_emerge/depgraph.py |
| 17 | > @@ -2240,6 +2240,7 @@ class depgraph: |
| 18 | > |
| 19 | > return None |
| 20 | > |
| 21 | > + @functools.lru_cache(maxsize=100) |
| 22 | > def _slot_operator_check_reverse_dependencies( |
| 23 | > self, existing_pkg, candidate_pkg, replacement_parent=None |
| 24 | > ): |
| 25 | |
| 26 | Merged. Thank you! |
| 27 | |
| 28 | https://gitweb.gentoo.org/proj/portage.git/commit/?id=0c42cc962e1926ecbdc83d903a2804f9e037f2a9 |
| 29 | https://gitweb.gentoo.org/proj/portage.git/commit/?id=839ab46be1777e5886da28b98b53a462b992c5bf |
| 30 | -- |
| 31 | Thanks, |
| 32 | Zac |