Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH 1/2] repoman: update cat/pkg info in header all the time
Date: Wed, 13 Jun 2012 00:12:40
Message-Id: 4FD7C643.4070308@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH 1/2] repoman: update cat/pkg info in header all the time by Mike Frysinger
1 On 06/12/2012 03:13 PM, Mike Frysinger wrote:
2 > There are edge cases where repoman's changelog code is not as good as
3 > the existing echangelog. Mostly related to out of date headers. Have
4 > the code check the header in more cases not just for missing lines, but
5 > also outdated values all the time.
6 >
7 > While we're at it, write some tests!
8 >
9 > Signed-off-by: Mike Frysinger <vapier@g.o>
10 > ---
11 > pym/portage/tests/repoman/test_echangelog.py | 101 ++++++++++++++++++++++++++
12 > pym/repoman/utilities.py | 57 ++++++++-------
13 > 2 files changed, 133 insertions(+), 25 deletions(-)
14 > create mode 100644 pym/portage/tests/repoman/test_echangelog.py
15
16 Looks good to me.
17 --
18 Thanks,
19 Zac