Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH 2/2] pym/portage/util/locale.py: add a C module to help check locale
Date: Fri, 27 May 2016 15:15:52
Message-Id: 20160527081502.3f6132d9.dolsen@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH 2/2] pym/portage/util/locale.py: add a C module to help check locale by "Anthony G. Basile"
1 On Fri, 27 May 2016 10:40:46 -0400
2 "Anthony G. Basile" <basile@××××××××××××××.edu> wrote:
3
4 > On 5/23/16 10:25 AM, Michał Górny wrote:
5 > > On Mon, 23 May 2016 08:08:18 -0400
6 > > "Anthony G. Basile" <basile@××××××××××××××.edu> wrote:
7 > >
8 > >> On 5/23/16 2:44 AM, Michał Górny wrote:
9 > >>> On Sun, 22 May 2016 13:04:40 -0400
10 > >>> "Anthony G. Basile" <basile@××××××××××××××.edu> wrote:
11 > >>>
12
13 > >
14 > > 1. I think old versions of Python did not support named properties
15 > > in sys.version_info, back when Portage was written.
16 >
17 > I didn't need this because I found _unicode_decode() which does what I
18 > want. Thanks for the clue. BTW, why are those functions/classes in
19 > pym/portage/__init__.py? All that code in there is just cluttering
20 > __init__.py. Shouldn't that stuff be pulled into a separate file and
21 > imported cleanly?
22 >
23
24 Yes, there is generally far too much code in many of the __init__.py's.
25 There are many with over 1K LOC
26
27 --
28 Brian Dolbec <dolsen>