Gentoo Archives: gentoo-portage-dev

From: "Göktürk Yüksek" <gokturk@××××××××××.edu>
To: gentoo-portage-dev@l.g.o
Subject: [gentoo-portage-dev] [PATCH] repoman: include HOME in the variable.readonly check
Date: Wed, 04 May 2016 07:51:49
Message-Id: 1462348287-5645-1-git-send-email-gokturk@binghamton.edu
1 According to the PMS section 11.1, HOME is a read-only
2 variable. Include it in the list of read-only variables for the
3 variable.readonly check in repoman.
4
5 Signed-off-by: Göktürk Yüksek <gokturk@××××××××××.edu>
6 ---
7 pym/repoman/modules/scan/ebuild/checks.py | 2 +-
8 1 file changed, 1 insertion(+), 1 deletion(-)
9
10 diff --git a/pym/repoman/modules/scan/ebuild/checks.py b/pym/repoman/modules/scan/ebuild/checks.py
11 index 8cdc230..5833d42 100644
12 --- a/pym/repoman/modules/scan/ebuild/checks.py
13 +++ b/pym/repoman/modules/scan/ebuild/checks.py
14 @@ -236,7 +236,7 @@ class EbuildAssignment(LineCheck):
15 """Ensure ebuilds don't assign to readonly variables."""
16
17 repoman_check_name = 'variable.readonly'
18 - read_only_vars = 'A|CATEGORY|P|P[VNRF]|PVR|D|WORKDIR|FILESDIR|FEATURES|USE'
19 + read_only_vars = 'A|CATEGORY|P|P[VNRF]|PVR|D|WORKDIR|FILESDIR|FEATURES|USE|HOME'
20 readonly_assignment = re.compile(r'^\s*(export\s+)?(%s)=' % read_only_vars)
21
22 def check(self, num, line):
23 --
24 2.7.3