Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] _dep_check_composite_db: select highest in slot conflict (bug 554070)
Date: Wed, 04 Jan 2017 22:28:28
Message-Id: 20170104142823.2e6b9b50.dolsen@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] _dep_check_composite_db: select highest in slot conflict (bug 554070) by Zac Medico
1 On Tue, 3 Jan 2017 17:13:25 -0800
2 Zac Medico <zmedico@g.o> wrote:
3
4 > Fix the _dep_check_composite_db._visible method to select the highest
5 > version involved in a slot conflict, for consistency with the change
6 > in ab07ac68fa1e04ed64e2e0f6c753ff169a32d517. The included unit test
7 > fails without this fix.
8 >
9 > Fixes: ab07ac68fa1e ("depgraph: select highest version involved in
10 > slot conflict (bug 554070)") X-Gentoo-Bug: 554070
11 > X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=554070
12 > ---
13 > pym/_emerge/depgraph.py | 8 +-
14 > .../resolver/test_imagemagick_graphicsmagick.py | 104
15 > +++++++++++++++++++++ 2 files changed, 110 insertions(+), 2
16 > deletions(-) create mode 100644
17 > pym/portage/tests/resolver/test_imagemagick_graphicsmagick.py
18 >
19
20
21 LGTM
22 --
23 Brian Dolbec <dolsen>

Replies