Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH 0/3] Let's standardise commit messages
Date: Sun, 30 Mar 2014 00:07:40
Message-Id: 20140329170714.4abaeedf.dolsen@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH 0/3] Let's standardise commit messages by Alexander Berntsen
1 On Thu, 27 Mar 2014 13:48:37 +0100
2 Alexander Berntsen <bernalex@g.o> wrote:
3
4 > The first two patches here are not interesting. The first one makes
5 > DEVELOPING cap at the same width as README. The second adds a "duh"
6 > paragraph on commits. They are only bundled with what I really wanna
7 > talk about because I need ACKs to push them anyway. (Please ACK them,
8 > someone.)
9 >
10 > So what I really wanna talk about are commit messages. They are sort
11 > of a mess. Let's just standardise them to something sane. I believe my
12 > suggestions are sane, and pretty much "what everybody does". The
13 > reason I wanna do "#number" for bugs is because a) we need the number
14 > for easy grep and of course to look up the relevant bug, and b)
15 > because '#' is a very grepable char for looking up recently fixed
16 > bugs with head or whatever.
17 >
18 > No bikeshedding, please. These are not very interesting things to talk
19 > about. Let's just form a decision. Object if you have an objection. If
20 > not, give me an ACK.
21 >
22 > Alexander Berntsen (3):
23 > DEVELOPING: Cap at 72 columns
24 > DEVELOPING: Add note on commits
25 > DEVELOPING: Add note on commit messages
26 >
27 > DEVELOPING | 98
28 > +++++++++++++++++++++++++++++++++++++++++--------------------- 1 file
29 > changed, 65 insertions(+), 33 deletions(-)
30 >
31
32
33 Ack on the revised commits. go ahead and commit. :) Thanks
34 --
35 Brian Dolbec <dolsen>