Gentoo Archives: gentoo-portage-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-portage-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: [gentoo-portage-dev] [PATCH 1/2] repoman: Add a new 'badinexp' warning class for exp profiles
Date: Wed, 10 Jan 2018 22:24:22
Message-Id: 20180110222415.25639-1-mgorny@gentoo.org
1 Add a new 'badinexp' (+ 'badmaskedinexp') warning class that is likewise
2 'badindev' but for 'exp' profiles. This will allow us to more
3 proactively inform developers of exp profile breakages without actually
4 making them fatal errors like they are now.
5 ---
6 repoman/man/repoman.1 | 8 ++++++++
7 repoman/pym/repoman/modules/scan/depend/profile.py | 2 ++
8 repoman/pym/repoman/qa_data.py | 8 ++++++++
9 3 files changed, 18 insertions(+)
10
11 diff --git a/repoman/man/repoman.1 b/repoman/man/repoman.1
12 index 813bdae21..b2542b0c7 100644
13 --- a/repoman/man/repoman.1
14 +++ b/repoman/man/repoman.1
15 @@ -288,6 +288,10 @@ ebuilds)
16 User-visible ebuilds with unsatisfied dependencies (matched against *visible*
17 ebuilds) in developing arch
18 .TP
19 +.B dependency.badinexp
20 +User-visible ebuilds with unsatisfied dependencies (matched against *visible*
21 +ebuilds) in experimental arch
22 +.TP
23 .B dependency.badmasked
24 Masked ebuilds with unsatisfied dependencies (matched against *all* ebuilds)
25 .TP
26 @@ -295,6 +299,10 @@ Masked ebuilds with unsatisfied dependencies (matched against *all* ebuilds)
27 Masked ebuilds with unsatisfied dependencies (matched against *all* ebuilds) in
28 developing arch
29 .TP
30 +.B dependency.badmaskedinexp
31 +Masked ebuilds with unsatisfied dependencies (matched against *all* ebuilds) in
32 +experimental arch
33 +.TP
34 .B dependency.badtilde
35 Uses the ~ dep operator with a non-zero revision part, which is useless (the
36 revision is ignored)
37 diff --git a/repoman/pym/repoman/modules/scan/depend/profile.py b/repoman/pym/repoman/modules/scan/depend/profile.py
38 index cf3d9a8f4..30d839af0 100644
39 --- a/repoman/pym/repoman/modules/scan/depend/profile.py
40 +++ b/repoman/pym/repoman/modules/scan/depend/profile.py
41 @@ -163,6 +163,8 @@ class ProfileDependsChecks(ScanBase):
42
43 if prof.status == "dev":
44 suffix = suffix + "indev"
45 + elif prof.status == "exp":
46 + suffix = suffix + "inexp"
47
48 for mytype in Package._dep_keys:
49
50 diff --git a/repoman/pym/repoman/qa_data.py b/repoman/pym/repoman/qa_data.py
51 index fed798f9f..c6abe1760 100644
52 --- a/repoman/pym/repoman/qa_data.py
53 +++ b/repoman/pym/repoman/qa_data.py
54 @@ -42,6 +42,12 @@ qahelp = {
55 "dependency.badmaskedindev": (
56 "Masked ebuilds with unsatisfied dependencies"
57 " (matched against *all* ebuilds) in developing arch"),
58 + "dependency.badinexp": (
59 + "User-visible ebuilds with unsatisfied dependencies"
60 + " (matched against *visible* ebuilds) in experimental arch"),
61 + "dependency.badmaskedinexp": (
62 + "Masked ebuilds with unsatisfied dependencies"
63 + " (matched against *all* ebuilds) in experimental arch"),
64 "dependency.badtilde": (
65 "Uses the ~ dep operator with a non-zero revision part,"
66 " which is useless (the revision is ignored)"),
67 @@ -249,6 +255,8 @@ qawarnings = set((
68 "dependency.badmasked",
69 "dependency.badindev",
70 "dependency.badmaskedindev",
71 + "dependency.badinexp",
72 + "dependency.badmaskedinexp",
73 "dependency.badtilde",
74 "dependency.missingslot",
75 "dependency.perlcore",
76 --
77 2.16.0.rc1

Replies