| 1 |
On Tue, 4 Aug 2020 21:56:08 -0400 |
| 2 |
Aaron Bauman <bman@g.o> wrote: |
| 3 |
|
| 4 |
> On Tue, Aug 04, 2020 at 09:43:03PM -0400, Aaron Bauman wrote: |
| 5 |
> > * This fixes the one instance of a trailing comma in the repo which |
| 6 |
> > actually causes a tuple to be created. |
| 7 |
> > |
| 8 |
> > Signed-off-by: Aaron Bauman <bman@g.o> |
| 9 |
> > --- |
| 10 |
> > lib/portage/repository/config.py | 2 +- |
| 11 |
> > 1 file changed, 1 insertion(+), 1 deletion(-) |
| 12 |
> > |
| 13 |
> > diff --git a/lib/portage/repository/config.py |
| 14 |
> > b/lib/portage/repository/config.py index 0f3e582f8..f4dd834b5 100644 |
| 15 |
> > --- a/lib/portage/repository/config.py |
| 16 |
> > +++ b/lib/portage/repository/config.py |
| 17 |
> > @@ -871,7 +871,7 @@ class RepoConfigLoader: |
| 18 |
> > continue |
| 19 |
> > if repo.masters is None: |
| 20 |
> > if self.mainRepo() and repo_name |
| 21 |
> > != self.mainRepo().name: |
| 22 |
> > - repo.masters = |
| 23 |
> > self.mainRepo(), |
| 24 |
> > + repo.masters = |
| 25 |
> > self.mainRepo() else: |
| 26 |
> > repo.masters = () |
| 27 |
> > else: |
| 28 |
> > -- |
| 29 |
> > 2.28.0 |
| 30 |
> > |
| 31 |
> > |
| 32 |
> |
| 33 |
> Please disregard this patch series. |
| 34 |
> |
| 35 |
Please don't enable this check. Pylint is stupid to enforce this one. |
| 36 |
When adding another item to the list or dictionary, it is better to |
| 37 |
have the tailing comma already in place. Git blame doesn't work if you |
| 38 |
have to add the comma to extend the list, etc.. It also adds |
| 39 |
unnecessary churn for something that does not affect operation in the |
| 40 |
slightest. |
| 41 |
|
| 42 |
Is one of the bad ones pylint wants to enforce. |
Archives