Re: [gentoo-portage-dev] --nodeps faulty behaviour?

[Markus Duft]

On Mon, 2009-04-20 at 02:14 -0700, Zac Medico wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Markus Duft wrote:
> > Hi!
> >
> > I have a quick question: is --nodeps supposed to still merge packages in
> > the right order?
>
> Yes. The attached patch should fix it. Thanks for reporting.

cool thanks :) so this patch makes portage merge in the order given on
the command line? this means it's the users fault if packages are in the
wrong order? shouldn't portage do the same thing as with --nodeps,
except that it doesn't add new packages to the merge list? don't get me
wrong - i'm quite happy with beeing responsible for the order, i just
imageined passing (to stay with the same example) "--nodeps texinfo
help2man" which should reorder to help2man beeing before texinfo, i
would guess... thoughts?

Cheers, Markus

>
> - --
> Thanks,
> Zac
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.11 (GNU/Linux)
>
> iEYEARECAAYFAknsPNIACgkQ/ejvha5XGaN6EQCfUWVR2U+gCrqv60uMzAssbzm0
> VxUAnjsah7byJwKRO/FVoZWwr0i4kBmE
> =X0E7
> -----END PGP SIGNATURE-----
> plain text document attachment (nodeps_order.patch)
> Index: pym/_emerge/__init__.py
> ===================================================================
> --- pym/_emerge/__init__.py	(revision 13376)
> +++ pym/_emerge/__init__.py	(revision 13377)
> @@ -7039,6 +7039,13 @@
>  			writemsg("\n", noiselevel=-1)
>
>  		scheduler_graph = self.digraph.copy()
> +
> +		if '--nodeps' in self.myopts:
> +			# Preserve the package order given on the command line.
> +			return ([node for node in scheduler_graph \
> +				if isinstance(node, Package) \
> +				and node.operation == 'merge'], scheduler_graph)
> +
>  		mygraph=self.digraph.copy()
>  		# Prune "nomerge" root nodes if nothing depends on them, since
>  		# otherwise they slow down merge order calculation. Don't remove