| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA256 |
| 3 |
|
| 4 |
On 25/07/14 00:11, Sergei Trofimovich wrote: |
| 5 |
> - assert(h.known_maintainer('sping')) |
| 6 |
> - assert(h.known_maintainer('sping@g.o')) |
| 7 |
> + assert(h.known_maintainer('slyfox')) |
| 8 |
> + assert(h.known_maintainer('slyfox@g.o')) |
| 9 |
> assert(not h.known_maintainer('portage')) |
| 10 |
> |
| 11 |
> assert(h.maintainer_in_herd('zmedico@g.o', 'tools-portage')) |
| 12 |
> assert(not h.maintainer_in_herd('pva@g.o', 'tools-portage')) |
| 13 |
> |
| 14 |
> + assert(h.herd_by_herd_email('haskell@g.o') == 'haskell') |
| 15 |
> + assert(h.herd_by_herd_email('slyfox@g.o') is None) |
| 16 |
> + |
| 17 |
This really doesn't belong in the same patch. |
| 18 |
|
| 19 |
If you split those, the patch looks good to me. Michał said it was fine too. |
| 20 |
|
| 21 |
However, I can't merge this until Tom gives me an ACK with regards to the repoman refactor. You also need some QA member (like Tom) to ACK it. |
| 22 |
|
| 23 |
I'll merge your reworked patches as soon as you have the appropriate ACKs. |
| 24 |
- -- |
| 25 |
Alexander |
| 26 |
bernalex@g.o |
| 27 |
https://secure.plaimi.net/~alexander |
| 28 |
-----BEGIN PGP SIGNATURE----- |
| 29 |
Version: GnuPG v2 |
| 30 |
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ |
| 31 |
|
| 32 |
iF4EAREIAAYFAlQHBMwACgkQRtClrXBQc7UJJwD/YUCoq5RuZrx31z+D/Q75P6uE |
| 33 |
97fpP01Efj3tI7cz4hwA/R/19w9aQ5ke5pnatRbAWSeQfU5UxooUXwtr6sN713XW |
| 34 |
=5KzR |
| 35 |
-----END PGP SIGNATURE----- |
Archives