Gentoo Archives: gentoo-portage-dev

From: Alexander Berntsen <bernalex@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] emerge: add --search-fuzzy and --search-fuzzy-cutoff options (bug 65566)
Date: Fri, 08 Apr 2016 11:33:15
Message-Id: 570796ED.8040608@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH] emerge: add --search-fuzzy and --search-fuzzy-cutoff options (bug 65566) by Zac Medico
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA512
3
4 On 08/04/16 08:21, Zac Medico wrote:
5 > Reverse? You want it to measure dissimilarity? Not sure what you
6 > mean.
7 Sorry, I meant reverse the *docs* to mean "find things that are at
8 least 50% similar" rather than "cut off things that aren't above the
9 0.5 threshold". I.e. use an inclusive sentence. I feel that this is
10 more clear.
11
12 > I just want it to fail if the input is invalid.
13 Yes, I just realised you checked if it were <=, not just <. I think
14 this is a bad idea. It's easily missed -- I just missed it last time
15 around. I would suggest to make it fail early, rather than set it to
16 0.0 which you then set to None. Just set it to None immediately.
17 - --
18 Alexander
19 bernalex@g.o
20 https://secure.plaimi.net/~alexander
21 -----BEGIN PGP SIGNATURE-----
22 Version: GnuPG v2
23
24 iQIcBAEBCgAGBQJXB5bsAAoJENQqWdRUGk8BSO8QAKXJlxYpetrA8kKbvW/cknoO
25 wrLPkHsmn7imnfQddcXVHtE+K1GJCRcG1Eu2VD+Pqza3HLRPl20eTm8+iu+maftk
26 K41+SCNEb8qs9v05P2wcqPxtUlzI4OO9GwJFJkbycRxgCFtCYnM/0B2kXaSKOkHr
27 KY4cF9CbdzfwIYL2FkmaCJrCBI9ac1sjsnug9yN+wXIYVV6nzpPLPq8QJU9P6sef
28 XI7na2mMHpK75FHl5fW/yVJfCXuBHmGgryfyEm+uUtvpLWpGceRBbRl4naJljbsf
29 AVNSocBmPdWGL6PCdfcD5MID8iriIBfTYWLsAoBN1HcKKasSKr1BG+UxT3wGov7n
30 STbQ7MLVQpDluS3kCgjbVNWUlouOcVhcNdOniC3GEDxzpT9ev7Tk/FilMNNu167N
31 l28SaGUokLQnf/EuQfQmNJJyHpFIVsxeRs5ODQZDlvb10WHDFMtYCkXZDhrLJmm6
32 Ej+tFJiuMWfAIejzVkJ0gvZTvg5FzVknvEey9iNokzXnOsngIjaR4gS8KjUUH0k8
33 EF1348cJ3KwQxbkWifsEuVosDmiSFaF38j73IoYaHOQh06bVPm2gL/zGeGntDGQY
34 X+RXL5XTJefiKps1jG4e96jYEUWIIlA/fodxkERKXcEmOsvT29v5gEAwcq6YGWXG
35 McLGDbOpF/n9tuxihQQK
36 =GgNP
37 -----END PGP SIGNATURE-----

Replies