| 1 |
On 10/02/2011 01:54 PM, Robin H. Johnson wrote: |
| 2 |
> On Sun, Oct 02, 2011 at 01:39:41PM -0700, Zac Medico wrote: |
| 3 |
>> On 10/02/2011 05:46 AM, Robin H. Johnson wrote: |
| 4 |
>>> On Sat, Oct 01, 2011 at 09:40:13PM -0700, Zac Medico wrote: |
| 5 |
>>>> If we control these hashes via metadata/layout.conf, then we can toggle |
| 6 |
>>>> it atomically for all commiters. Otherwise, we'll have an annoying |
| 7 |
>>>> period of time where different committers are committing different sets |
| 8 |
>>>> of hashes, depending on their portage version. |
| 9 |
>>> How do you suggest doing it via layout.conf? I've kept SHA256 in both |
| 10 |
>>> sets for now, but if you could enforce new signatures including both |
| 11 |
>>> WHIRLPOOL and SHA256, that would be great. |
| 12 |
>> How about if we put something like this in |
| 13 |
>> gentoo-x86/metadata/layout.conf now: |
| 14 |
> Did you mean profiles/layout.conf? I just want to make sure no scripts |
| 15 |
> that pull from CVS and expect that dir to not exist don't break. |
| 16 |
|
| 17 |
No, it's metadata/layout.conf. I didn't choose the location. We actually |
| 18 |
inherited it from paludis about 1.5 years ago: |
| 19 |
|
| 20 |
|
| 21 |
http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=f16aee82cefa95e9903fa46f448d30f6d4350f64 |
| 22 |
|
| 23 |
We're also using it to control thin-manifest support, among other things |
| 24 |
now: |
| 25 |
|
| 26 |
https://bugs.gentoo.org/show_bug.cgi?id=333691 |
| 27 |
|
| 28 |
>> manifest2-sha1 = true |
| 29 |
>> manifest2-whirlpool = false |
| 30 |
> Bikeshedding slightly, but can we figure something like a list or dict |
| 31 |
> instead? (Also gives us a chance to make the required hashes a list). |
| 32 |
> manifest2-hashes = ['SHA1', 'SHA256', 'RMD160'] |
| 33 |
|
| 34 |
Well, booleans are simpler. Also, note that I designed them to be |
| 35 |
removed from layout.conf eventually, which means that we will accumulate |
| 36 |
less bloat in layout.conf over time. |
| 37 |
|
| 38 |
>> Then we'll patch portage so that by default it will disable SHA1 and |
| 39 |
>> enable WHIRLPOOL, and the above settings will override the defaults. |
| 40 |
>> After the patched portage is marked stable in a month or so, we'll send |
| 41 |
>> an announcement to gentoo-announce, and remove the above settings from |
| 42 |
>> layout.conf. |
| 43 |
> Sounds good to me. Hopefully I'll have more of the MetaManifest |
| 44 |
> prototype code in the next few days to go live around the same time. |
| 45 |
|
| 46 |
I'll see if I can get a layout.conf patch done today. |
| 47 |
-- |
| 48 |
Thanks, |
| 49 |
Zac |
Archives