Gentoo Archives: gentoo-portage-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH v4] rsync: Introduce support for running full-tree gemato verification
Date: Thu, 25 Jan 2018 08:01:31
Message-Id: 1516867285.1833.1.camel@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH v4] rsync: Introduce support for running full-tree gemato verification by Zac Medico
1 W dniu śro, 24.01.2018 o godzinie 13∶56 -0800, użytkownik Zac Medico
2 napisał:
3 > On 01/24/2018 01:36 PM, Michał Górny wrote:
4 > > Add two new configuration options to rsync repositories:
5 > > sync-rsync-verify-metamanifest and sync-rsync-openpgp-key-path.
6 > > The first controls whether gemato verification is run for
7 > > the repository (defaults to true for ::gentoo, false otherwise),
8 > > the second makes it possible to override the key path for custom
9 > > repositories.
10 > > ---
11 > > cnf/repos.conf | 2 ++
12 > > man/portage.5 | 9 +++++++++
13 > > pym/portage/sync/modules/rsync/__init__.py | 4 +++-
14 > > pym/portage/sync/modules/rsync/rsync.py | 20 +++++++++++++++++++-
15 > > 4 files changed, 33 insertions(+), 2 deletions(-)
16 > >
17 > > v4: also key option to repos.conf
18 >
19 > Looks good.
20 >
21 > I see that the man page currently does not escape hyphens in
22 > sync-rsync-*, but we can fix those up separately.
23
24 Fixed that and pushed. Thanks! Note however that the hyphens
25 in adjoining entries that I haven't modified are still unescaped.
26
27 --
28 Best regards,
29 Michał Górny