Gentoo Archives: gentoo-portage-dev

From: Alexander Berntsen <bernalex@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH v2] egencache: add --stable-mtime option
Date: Mon, 21 Dec 2015 15:05:13
Message-Id: 5678151A.9010306@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH v2] egencache: add --stable-mtime option by Zac Medico
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA512
3
4 The patch looks OK.
5
6 On 20/12/15 23:32, Zac Medico wrote:
7 > Since the Manifest "stable mtime" behavior could be have
8 > undiscovered bugs, disable it by default, and add a corresponding
9 > egencache option.
10 You have an English børk here -- "could be have".
11
12 > [PATCH v2] fixes preserved_stats to contain stat results for
13 > self.pkgdir even if the Manifest has been removed, and also
14 > explains the reasoning for disabling the stable mtime behavior by
15 > default.
16 Maybe this could go into the commit message? I'd not mind a more
17 verbose message for this.
18
19 - --
20 Alexander
21 bernalex@g.o
22 https://secure.plaimi.net/~alexander
23 -----BEGIN PGP SIGNATURE-----
24 Version: GnuPG v2
25
26 iQIcBAEBCgAGBQJWeBUaAAoJENQqWdRUGk8Bc8wQALHRzKQUdHzl8oGgzCvhvvCn
27 YSX3JT+R7OcDbIxy+JjDQ88Mh2DQf2JfEcAmUcL/lA0grAJ+xV5dYwOnRIEbqYZM
28 sTK+oIxIs0awOQa/qKvUCwpP8hBLB4CM95ECwFWMb1JvOWnP3+czuXz74DIrhmRC
29 3P6JVPOzF7oaNDx/WdHPYyp1un6jQRCAsnwWmSMA1DFzbpE9S94C9uFzWQDha/Kk
30 0pOZJmqYciCxUa0v7rcQCuJqdYmyHgN5wfaYN/bUC2YO+7IkTvM7EkI3avg95fK5
31 BsTGKZfse4x5VYBZ+urEl7w/rNLG6BvpWnpz3BELVE792It/+vazq1e/ceC582Zy
32 I69jidlP7xH5+0VpcUx0LVaPJ/x5qZ/18Jhwt4JAGgehKdneOp+JefhfhZ+im6n7
33 KTH/D6gtVmg+MkL51JTcVLXsWeCpwVbm1fPzi31+T3zqngiLKtNxUaIhlLVyJQNZ
34 JMl/GBGpXiyA7Ig9l7g2cBqUWAj3GcYk20XikEY3oTnxT3rQzIMP8GGpTFA4wYUf
35 88aSo+VFyr02nOHXtmyTugpvPlXxwjMxFhQ04+j57NR39Y4zfpteiNRb9o8yYxKu
36 3rOoexmqY3U7z49qPLaA+Gnf810v+Jw6Hwv0CNPjhCSbB705acTDpaAGLhj/hvXv
37 Dg7KrpzMqt5mYsPYIzLB
38 =iK0o
39 -----END PGP SIGNATURE-----

Replies