Archives
Archives
| From: | Zac Medico <zmedico@g.o> | ||
|---|---|---|---|
| To: | gentoo-portage-dev@l.g.o | ||
| Subject: | Re: [gentoo-portage-dev] [RFC/PATCH] prepstrip/ecompressdir: parallelize operations | ||
| Date: | Fri, 11 May 2012 18:09:01 | ||
| Message-Id: | 4FAD4D3E.3010004@gentoo.org | ||
| In Reply to: | [gentoo-portage-dev] [RFC/PATCH] prepstrip/ecompressdir: parallelize operations by Mike Frysinger |
||
| 1 | On 05/11/2012 09:39 AM, Mike Frysinger wrote: |
| 2 | > +multijob_finish() { |
| 3 | > + local ret=0 |
| 4 | > + while [[ ${mj_num_jobs} -gt 0 ]] ; do |
| 5 | > + multijob_finish_one |
| 6 | > + : $(( ret += $? )) |
| 7 | > + done |
| 8 | > + # Let bash clean up its internal child tracking state. |
| 9 | > + wait |
| 10 | > + return ${ret} |
| 11 | > +} |
| 12 | |
| 13 | Wouldn't it be better to use $(( ret |= $? )) there, in order to avoid a |
| 14 | possible integer overflow? Other than that, the patch looks good to me. |
| 15 | -- |
| 16 | Thanks, |
| 17 | Zac |
| Subject | Author |
|---|---|
| Re: [gentoo-portage-dev] [RFC/PATCH] prepstrip/ecompressdir: parallelize operations | Mike Frysinger <vapier@g.o> |