Archives
Archives
| From: | Alec Warner <antarus@g.o> | ||
|---|---|---|---|
| To: | gentoo-portage-dev@l.g.o | ||
| Subject: | Re: [gentoo-portage-dev] [PATCH] global_event_loop: use asyncio event loop (bug 654390) | ||
| Date: | Tue, 08 May 2018 15:55:18 | ||
| Message-Id: | CAAr7Pr-vOn3zMK86r8Czpj8PkanSiFLjtEU-3zQ63gm5Bcm1UQ@mail.gmail.com | ||
| In Reply to: | Re: [gentoo-portage-dev] [PATCH] global_event_loop: use asyncio event loop (bug 654390) by Brian Dolbec |
||
| 1 | lgtm. |
| 2 | |
| 3 | -A |
| 4 | |
| 5 | On Tue, May 8, 2018 at 11:43 AM, Brian Dolbec <dolsen@g.o> wrote: |
| 6 | |
| 7 | > On Mon, 7 May 2018 03:18:32 -0700 |
| 8 | > Zac Medico <zmedico@g.o> wrote: |
| 9 | > |
| 10 | > > + # This attribute it used by _wrap_loop to detect if |
| 11 | > > the |
| 12 | > |
| 13 | > typo, s/it/is |
| 14 | > |
| 15 | > this asynio stuff is mostly beyond my familiarity... but all looks ok, |
| 16 | > and I know you ran the tests on it... |
| 17 | > |
| 18 | > should be good to merge unless anyone else objects... |
| 19 | > |
| 20 | > -- |
| 21 | > Brian Dolbec <dolsen> |
| 22 | > |
| 23 | > |
| 24 | > |
| Subject | Author |
|---|---|
| Re: [gentoo-portage-dev] [PATCH] global_event_loop: use asyncio event loop (bug 654390) | Zac Medico <zmedico@g.o> |