Gentoo Archives: gentoo-portage-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH v2] misc: Distribute a repo.postsync.d hook to run gemato verification
Date: Wed, 17 Jan 2018 15:25:48
Message-Id: 1516202741.17361.1.camel@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH v2] misc: Distribute a repo.postsync.d hook to run gemato verification by Zac Medico
1 W dniu wto, 16.01.2018 o godzinie 11∶32 -0800, użytkownik Zac Medico
2 napisał:
3 > On 01/16/2018 10:39 AM, Michał Górny wrote:
4 > > W dniu wto, 16.01.2018 o godzinie 12∶44 -0500, użytkownik Alec Warner
5 > > napisał:
6 > > > On Tue, Jan 16, 2018 at 11:43 AM, Michał Górny <mgorny@g.o> wrote:
7 > > >
8 > > > > Include a repo.postsync.d hook to verify the rsync checkout using
9 > > > > gemato. Given that not all people will want to have it enabled
10 > > > > unconditionally, no setup.py rules are included -- instead, the file
11 > > > > would be installed conditionally by the ebuild.
12 > > > >
13 > > > > [v2: included link to the wiki page]
14 > > > > ---
15 > > > > MANIFEST.in | 2 +-
16 > > > > misc/repo.postsync.d/00gemato | 18 ++++++++++++++++++
17 > > > > 2 files changed, 19 insertions(+), 1 deletion(-)
18 > > > > create mode 100644 misc/repo.postsync.d/00gemato
19 > > > >
20 > > > > diff --git a/MANIFEST.in b/MANIFEST.in
21 > > > > index 4f6cac162..edc6704e7 100644
22 > > > > --- a/MANIFEST.in
23 > > > > +++ b/MANIFEST.in
24 > > > > @@ -14,4 +14,4 @@ include cnf/make.conf.example.*
25 > > > > include .portage_not_installed
26 > > > >
27 > > > > # extra scripts
28 > > > > -include misc/*
29 > > > > +graft misc
30 > > > > diff --git a/misc/repo.postsync.d/00gemato b/misc/repo.postsync.d/00gemato
31 > > > > new file mode 100644
32 > > > > index 000000000..f2af50925
33 > > > > --- /dev/null
34 > > > > +++ b/misc/repo.postsync.d/00gemato
35 > > > > @@ -0,0 +1,18 @@
36 > > > > +#!/bin/bash
37 > > > > +# repo.postsync.d hook to verify ::gentoo checkout using gemato
38 > > > > +
39 > > > > +name=${1}
40 > > > > +url=${2}
41 > > > > +path=${3}
42 > > > > +
43 > > > > +# keyring installed by gentoo-keys
44 > > > > +openpgp_key=/var/lib/gentoo/gkeys/keyrings/gentoo/release/pubring.gpg
45 > > > >
46 > > >
47 > > > This seems a bit leaky to me.
48 > > >
49 > > > Possible to get gentoo-keys to print it?
50 > > >
51 > > > e.g:
52 > > >
53 > > > openpgp_key=$(gentoo-keys --print-key-path)
54 > >
55 > > But app-crypt/gentoo-keys doesn't include that executable, and it has
56 > > no dependency on app-crypt/gkeys. I'd rather not introduce an artificial
57 > > dependency here.
58 >
59 > I suppose we could using a separate ebuild to install this hook, so that
60 > we can update it separately from portage if necessary. The hook can
61 > still live in the portage repository (like emerge-delta-webrsync which
62 > is also installed by a separate ebuild).
63
64 I don't see a strong reason to add yet another rebuild for a single file
65 that is going to be updated really rarely. However, if we're going to do
66 it that way, then there's no point in putting it in Portage repository.
67
68 However, this 'update it separately from portage' reminds me of repoman
69 that frequently gets seriously outdated and/or incompatible with Portage
70 because of independent release cycle...
71
72 --
73 Best regards,
74 Michał Górny

Replies