Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o, Michael 'veremitz' Everitt <gentoo@×××××××.xyz>
Subject: Re: [gentoo-portage-dev] [PATCH gentoolkit 1/2] eclean: Rewrite findPackages()
Date: Mon, 02 Mar 2020 06:26:07
Message-Id: 2a250d52-b983-9789-a239-7a3a418c681c@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH gentoolkit 1/2] eclean: Rewrite findPackages() by Michael 'veremitz' Everitt
1 On 2/20/20 9:36 PM, Michael 'veremitz' Everitt wrote:
2 > On 21/02/20 05:29, Matt Turner wrote:
3 >> I found the original code to be nearly incomprehensible. Instead of
4 >> populating a dict of potential binpkgs to remove and then removing from
5 >> the to-be-removed list, just selectively add to-be-removed packages.
6 >>
7 >> Signed-off-by: Matt Turner <mattst88@g.o>
8 >> ---
9 >> I switched from tabs to spaces in the process. I can revert back if
10 >> desired.
11 >>
12 > Probably best to stick to tabs for consistency with the other portage code,
13 > although naturally Zac probably better to ACK/NACK that.
14
15 Yeah lets stick with tabs unless we're converting everything to spaces.
16
17 > Otherwise I think this is a good refresh. +1.
18
19 Yes, looks good.
20 --
21 Thanks,
22 Zac