Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] emerge: check for writable /var/db/pkg (490732)
Date: Tue, 18 Nov 2014 16:42:18
Message-Id: 546B76E5.3010902@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH] emerge: check for writable /var/db/pkg (490732) by Brian Dolbec
1 On 11/18/2014 02:57 AM, Brian Dolbec wrote:
2 > On Tue, 18 Nov 2014 01:19:01 -0800
3 > Zac Medico <zmedico@g.o> wrote:
4 >
5 >> If there are packages to be merged or unmerge, then bail out early if
6 >> /var/db/pkg is not writable.
7 >>
8 > ...
9 >
10 >> diff --git a/pym/portage/dbapi/vartree.py
11 >> b/pym/portage/dbapi/vartree.py index 0fd1bd9..64b0ff6 100644
12 >> --- a/pym/portage/dbapi/vartree.py
13 >> +++ b/pym/portage/dbapi/vartree.py
14 >> @@ -33,6 +33,7 @@ portage.proxy.lazyimport.lazyimport(globals(),
15 >> 'portage.util.env_update:env_update',
16 >> 'portage.util.listdir:dircache,listdir',
17 >> 'portage.util.movefile:movefile',
18 >> + 'portage.util.path:first_existing',
19 >> 'portage.util.writeable_check:get_ro_checker',
20 >
21 > ^^^^^^^^^^^^^^^^^^^^^^^^
22 > That's what this was suppose to fix I thought
23
24 The writeable_check module is designed to check write access for the
25 files to be merged, and it's only used just prior to merge, when the
26 list of files is known.
27
28 The vardbapi.writable check that I have implemented provides a much
29 earlier warning, before anything has even been built.
30 --
31 Thanks,
32 Zac