Re: [gentoo-portage-dev] [PATCH] runtests: rewrite in python

[Mike Gilbert]

On Sat, May 30, 2015 at 1:18 PM, Brian Dolbec <dolsen@g.o> wrote:
> On Sat, 30 May 2015 12:29:14 -0400
> Mike Frysinger <vapier@g.o> wrote:
>
>> The bash was getting ugly, and this allows us to add more smarts
>> sanely to the main script.
>> ---
>>  DEVELOPING  |   2 +-
>>  runtests    | 156
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> runtests.sh | 109 ------------------------------------------ 3 files
>> changed, 157 insertions(+), 110 deletions(-) create mode 100755
>> runtests delete mode 100755 runtests.sh
>>
>> diff --git a/DEVELOPING b/DEVELOPING
>> index 0b0bb60..31b5594 100644
>> --- a/DEVELOPING
>> +++ b/DEVELOPING
>> @@ -225,7 +225,7 @@ Second create a git tag for this release:
>>  Then create the tarball and run the tests:
>>       ./mkrelease.sh --changelog-rev v2.2.7 --tag --runtests 2.2.8
>>  Make sure you have all supported python versions installed first
>> -(see PYTHON_SUPPORTED_VERSIONS in runtests.sh).
>> +(see PYTHON_SUPPORTED_VERSIONS in runtests).
>>
>>  Version bump the ebuild and verify it can re-install itself:
>>       emerge portage
>> diff --git a/runtests b/runtests
>> new file mode 100755
>> index 0000000..d1f7b6f
>> --- /dev/null
>> +++ b/runtests
>> +
>
>
>> +from __future__ import print_function
>>
>
> If I'm not mistaken, this is not needed for 2.7+ anymore.  It is
> still for 2.6 though.

You are mistaken. Without this, print is still treated as a statement
and anything in parens is treated as a tuple.

% python2.7 --version
Python 2.7.10

% python2.7 -c "print(1, 2, 3)"
(1, 2, 3)

% python2.7 -c "from __future__ import print_function; print(1, 2, 3)"
1 2 3