Gentoo Archives: gentoo-portage-dev

From: Mike Gilbert <floppym@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] bin/doins.py: implement install -p option (bug 642632)
Date: Fri, 29 Dec 2017 22:13:39
Message-Id: CAJ0EP438L9-9MPQVJUDm0Qc59MO4BhjDZ6bty26bDLVxGNqyHw@mail.gmail.com
In Reply to: [gentoo-portage-dev] [PATCH] bin/doins.py: implement install -p option (bug 642632) by Zac Medico
1 On Fri, Dec 29, 2017 at 3:35 PM, Zac Medico <zmedico@g.o> wrote:
2 > + if self._parsed_options.preserve_timestamps:
3 > + if sys.version_info >= (3, 3):
4 > + os.utime(dest, ns=(sstat.st_mtime_ns, sstat.st_mtime_ns))
5 > + else:
6 > + os.utime(dest, (sstat.st_mtime, sstat.st_mtime))
7
8 It looks like you are copying mtime into both mtime and atime on the
9 new file. Is that a mistake?

Replies