Re: [gentoo-portage-dev] use* cleanup

[Mike Frysinger]

On Thursday 01 November 2007, Marijn Schouten (hkBst) wrote:
> Mike Frysinger wrote:
> > On Wednesday 31 October 2007, Marijn Schouten (hkBst) wrote:
> >> The immediate motivation of my examining this code was a request on
> >> #gentoo-dev-help by lack for something which I could with my new code
> >> easily write like this:
> >>
> >> use_mime() {
> >>     local WORD="$(_if $2 $2 $1)"
> >>
> >>     _use $1 "${WORD};"
> >> }
> >
> > write where ?  in eclasses/ebuilds ?
>
> yes

then there are problems:
 - exported interfaces that people are expected to utilize should never ever 
start with an underscore
 - this is an API change which means you need to propose it and get it 
accepted on the gentoo-dev mailing list

> >>     if hasq ${flag} ${USE} ; then
> >> 	echo ${string_success}; return ${found}
> >>     else
> >> 	echo ${string_failure}; return $((!found))
> >>     fi
> >
> > no point in cuddling those lines
>
> Hmm, cuddling? I don't know what that means in this context.

it means there's no good reason for doing the echo/return on the same line
-mike