Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] egencache: Delay updating Manifests until all other tasks complete
Date: Thu, 12 Nov 2015 18:38:58
Message-Id: 20151112103803.48607c71.dolsen@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH] egencache: Delay updating Manifests until all other tasks complete by Zac Medico
1 On Thu, 12 Nov 2015 08:56:34 -0800
2 Zac Medico <zmedico@g.o> wrote:
3
4 > On 11/12/2015 08:35 AM, Zac Medico wrote:
5 > > On 11/12/2015 07:00 AM, Michał Górny wrote:
6 > >> Since thick Manifests can reference other files (ChangeLogs
7 > >> especially), their generation should be run as the lask task done
8 > >> by egencache, followed only by timestamp update.
9 > >
10 > > GenPkgDescIndex needs to execute last, since it accesses the
11 > > metadata.
12 >
13 > Actually, the patch looks good.
14 >
15 > I was confusing the manifest generation with the metadata generation.
16
17 actually, looks like Robin made a bug for this after you submitted this
18 patch.
19
20 Can you edit the commit message, add the bug please. Bug 565626
21
22 --
23 Brian Dolbec <dolsen>