Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH v2] svn sync: fix the module
Date: Sun, 18 Jan 2015 16:36:49
Message-Id: 20150118083628.1d382a63.dolsen@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH v2] svn sync: fix the module by "Michał Górny"
1 On Sun, 18 Jan 2015 11:35:18 +0100
2 Michał Górny <mgorny@g.o> wrote:
3
4 > Fix the svn sync module since it doesn't work at all right now. More
5 > specifically:
6 >
7 > 1. add exists() method that checks for the '.svn' directory to
8 > determine whether the repository was checked out already.
9 >
10 > 2. Fix the initial clone to use valid svn commands. Do not remove
11 > the just-created (in pre_sync()) directory to avoid permission issues,
12 > just run checkout on top of it.
13 >
14 > 3. Fix the sync method to run update unconditionally to whether the
15 > URI starts with svn:// or not. In fact, remove the whole check since
16 > it doesn't serve any purpose.
17 > ---
18 > pym/portage/sync/modules/svn/svn.py | 42
19 > +++++++++++++++---------------------- 1 file changed, 17
20 > insertions(+), 25 deletions(-)
21 >
22 >
23
24 Looks good, thank you for this update.
25
26 --
27 Brian Dolbec <dolsen>