Gentoo Archives: gentoo-portage-dev

From: Ali Polatel <hawking@g.o>
To: gentoo-portage-dev@l.g.o
Subject: [gentoo-portage-dev] [PATCH 2/6] Replace has_key() with the in operator (portage.cache)
Date: Tue, 01 Jul 2008 11:27:17
Message-Id: 1214911614-31263-2-git-send-email-hawking@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH 1/6] Replace has_key() with the in operator (portage) by Ali Polatel
1 ---
2 pym/portage/cache/metadata_overlay.py | 2 +-
3 pym/portage/cache/sql_template.py | 2 +-
4 2 files changed, 2 insertions(+), 2 deletions(-)
5
6 diff --git a/pym/portage/cache/metadata_overlay.py b/pym/portage/cache/metadata_overlay.py
7 index 13d1278..e25759c 100644
8 --- a/pym/portage/cache/metadata_overlay.py
9 +++ b/pym/portage/cache/metadata_overlay.py
10 @@ -61,7 +61,7 @@ class database(template.database):
11
12 def _delitem(self, cpv):
13 value = self[cpv] # validates whiteout and/or raises a KeyError when necessary
14 - if self.db_ro.has_key(cpv):
15 + if cpv in self.db_ro:
16 self.db_rw[cpv] = self._create_whiteout(value)
17 else:
18 del self.db_rw[cpv]
19 diff --git a/pym/portage/cache/sql_template.py b/pym/portage/cache/sql_template.py
20 index f32a728..3c5cbd4 100644
21 --- a/pym/portage/cache/sql_template.py
22 +++ b/pym/portage/cache/sql_template.py
23 @@ -150,7 +150,7 @@ class SQLDatabase(template.database):
24 # so we store only what's handed to us and is a known key
25 db_values = []
26 for key in self._known_keys:
27 - if values.has_key(key) and values[key] != '':
28 + if key in values and values[key] != '':
29 db_values.append({"key":key, "value":values[key]})
30
31 if len(db_values) > 0:
32 --
33 1.5.6.1
34
35 --
36 gentoo-portage-dev@l.g.o mailing list

Replies