Gentoo Archives: gentoo-portage-dev

From: Ulrich Mueller <ulm@g.o>
To: Zac Medico <zmedico@g.o>
Cc: "Michał Górny" <mgorny@g.o>, gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] config.environ: delay export of A and AA (bug 720180)
Date: Tue, 26 May 2020 17:32:42
Message-Id: u8shesitq@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH] config.environ: delay export of A and AA (bug 720180) by Zac Medico
1 >>>>> On Tue, 26 May 2020, Zac Medico wrote:
2
3 > On 5/26/20 12:48 AM, Michał Górny wrote:
4 >> On Mon, 2020-05-25 at 21:31 -0700, Zac Medico wrote:
5 >>> Since variables like A and AA can contain extremely large values which
6 >>> may trigger E2BIG errors during attempts to execute subprocesses, delay
7 >>> export until the last moment, and unexport when appropriate.
8 >>
9 >> Please don't. This will only hide the problem from developers who will
10 >> unknowingly commit broken ebuilds and cause users of alternative package
11 >> managers to suffer.
12
13 > We've seen in https://bugs.gentoo.org/719202 that developers can already
14 > do that with existing versions of portage, since the failure can be
15 > dependent on USE configuration.
16
17 We have seen in bug 719202 that A has exceeded _SC_ARG_MAX which is
18 128 KiB.
19
20 However, your commit message mentions E2BIG which will trigger at a much
21 larger value, namely 2 MiB. We are far away from reaching that limit in
22 any ebuild.
23
24 These are separate issues (although related), so I think we should make
25 it very clear about which one we're talking.
26
27 Ulrich

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies